Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(versioning/ubuntu): Fix test failing due to new release rolling out #15210

Conversation

Gabriel-Ladzaretti
Copy link
Collaborator

@Gabriel-Ladzaretti Gabriel-Ladzaretti commented Apr 20, 2022

Changes

Freeze isStable tests.

Context

Closes #15216

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Gabriel-Ladzaretti Gabriel-Ladzaretti force-pushed the fix-versioning-ubuntu-remove-failing-tests branch from 96b3713 to 0bdd907 Compare April 20, 2022 21:26
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mock time in tests, we already do it on node versioning for that same reason

@viceice
Copy link
Member

viceice commented Apr 21, 2022

DateTime.local = (...args: (string | any)[]) =>

@Gabriel-Ladzaretti Gabriel-Ladzaretti force-pushed the fix-versioning-ubuntu-remove-failing-tests branch from 1096766 to e595f68 Compare April 21, 2022 11:17
@Gabriel-Ladzaretti Gabriel-Ladzaretti changed the title fix(versioning/ubuntu): Temporally remove failing tests due to new release roll out fix(versioning/ubuntu): Fix test failing due to new release rolling out Apr 21, 2022
@Gabriel-Ladzaretti
Copy link
Collaborator Author

Gabriel-Ladzaretti commented Apr 21, 2022

mock time in tests, we already do it on node versioning for that same reason

I think this might be cleaner, as its using a build in functionality and is used as a test wrapper in Luxon itself.

https://github.com/moment/luxon/blob/aa6ab8b53f9ceab6f9d984575660d679622297ca/test/helpers.js#L18-L29

@rarkins
Copy link
Collaborator

rarkins commented Apr 21, 2022

Coverage:
image

@Gabriel-Ladzaretti
Copy link
Collaborator Author

Gabriel-Ladzaretti commented Apr 21, 2022

added // istanbul ignore next: unreachable as we dont have unreleased version in out distro data file

aaaand fixed the typo ^^ 😂

@Gabriel-Ladzaretti Gabriel-Ladzaretti force-pushed the fix-versioning-ubuntu-remove-failing-tests branch from 506505b to 4a51e35 Compare April 21, 2022 11:33
rarkins
rarkins previously approved these changes Apr 21, 2022
@rarkins rarkins enabled auto-merge (squash) April 21, 2022 11:46
lib/modules/versioning/ubuntu/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/versioning/ubuntu/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/versioning/ubuntu/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/versioning/ubuntu/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/ubuntu/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/versioning/ubuntu/index.spec.ts Outdated Show resolved Hide resolved
auto-merge was automatically disabled April 21, 2022 13:43

Head branch was pushed to by a user without write access

@viceice viceice enabled auto-merge (squash) April 21, 2022 14:51
@viceice viceice changed the title fix(versioning/ubuntu): Fix test failing due to new release rolling out test(versioning/ubuntu): Fix test failing due to new release rolling out Apr 21, 2022
@rarkins rarkins disabled auto-merge April 21, 2022 15:06
@rarkins rarkins merged commit 2288ce0 into renovatebot:main Apr 21, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.27.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
@Gabriel-Ladzaretti Gabriel-Ladzaretti deleted the fix-versioning-ubuntu-remove-failing-tests branch June 26, 2022 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu versioning tests should not fail once special dates have passed
4 participants