Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager/nuget): quote arguments #15226

Merged
merged 1 commit into from
Apr 21, 2022
Merged

fix(manager/nuget): quote arguments #15226

merged 1 commit into from
Apr 21, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Apr 21, 2022

Changes

  • quote all variable arguments
  • fix some test code style

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins April 21, 2022 12:51
@rarkins rarkins changed the title fix(manager:nuget): quote arguments fix(manager/nuget): quote arguments Apr 21, 2022
@rarkins rarkins merged commit cf57025 into main Apr 21, 2022
@rarkins rarkins deleted the fix/nuget-manager-quotes branch April 21, 2022 13:05
@css-inverso
Copy link

Hi,

the unit tests seem to fail on windows because the config path gets quoted.

@viceice
Copy link
Member Author

viceice commented Apr 21, 2022

@rarkins should we revert this? 😕 not able to fix that until tomorrow

@viceice
Copy link
Member Author

viceice commented Apr 22, 2022

@css-inverso PR on the way

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.27.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dotnet restore failed with MSB1001: Unknown switch
4 participants
@viceice @css-inverso @renovate-release @rarkins