New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(versioning/distro): Move date handling into distro.ts #15271
Merged
viceice
merged 12 commits into
renovatebot:main
from
Gabriel-Ladzaretti:refactor-distro-handle-dates
May 11, 2022
Merged
refactor(versioning/distro): Move date handling into distro.ts #15271
viceice
merged 12 commits into
renovatebot:main
from
Gabriel-Ladzaretti:refactor-distro-handle-dates
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved all time/date handling into distro.ts - date freeze for ubuntu/distro unit tests
6 tasks
viceice
reviewed
Apr 23, 2022
- restore deleted test cases for ubuntu unit tests
viceice
requested changes
Apr 24, 2022
- removed distro time mocking
viceice
reviewed
Apr 26, 2022
- DistroInfo constructor is no longer date dependent - Restored DateTime mock
viceice
reviewed
May 2, 2022
- convert a while to a for loop
Gabriel-Ladzaretti
force-pushed
the
refactor-distro-handle-dates
branch
from
May 2, 2022 07:14
0bea310
to
6560a2c
Compare
viceice
reviewed
May 4, 2022
viceice
reviewed
May 4, 2022
- unit tests went further back in time
viceice
reviewed
May 4, 2022
viceice
reviewed
May 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small neat
…riel-Ladzaretti/renovate into refactor-distro-handle-dates
viceice
approved these changes
May 11, 2022
🎉 This PR is included in version 32.49.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
moved all time/date handling into distro.ts
date freeze for ubuntu/distro unit tests
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: