-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cache): Compression for repository cache #15289
feat(cache): Compression for repository cache #15289
Conversation
Compression rate is about x4 |
what about buildin zlib? |
or pure js snappy |
This comment was marked as outdated.
This comment was marked as outdated.
In this case, I think it makes sense to stick to built-in |
My primary objective was to prefer speed over compression rate, but pure JS implementation is twice slower anyway |
For Brotli algorithm, compression rate is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM.
can you check that the new code and also tests are null safe?
🎉 This PR is included in version 32.31.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
snappy
algorithmContext
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: