Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npm): add detection for overrides block #15351

Merged
merged 19 commits into from May 17, 2022

Conversation

hasanwhitesource
Copy link
Contributor

Changes

Added support for extracting dependencies from the "overrides" block in package.json.
Relevant info on the new block handling : https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides

Context

Closes #15278

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@hasanwhitesource
Copy link
Contributor Author

Example of a pr :
image

hasanwhitesource/renovate-repro-npm-overrides#2

@hasanwhitesource hasanwhitesource marked this pull request as ready for review April 28, 2022 13:35
lib/modules/manager/npm/extract/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/types.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/index.ts Outdated Show resolved Hide resolved
@rarkins rarkins marked this pull request as draft April 29, 2022 07:35
@hasanwhitesource hasanwhitesource marked this pull request as ready for review May 8, 2022 06:47
lib/modules/manager/npm/extract/types.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/types.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/types.ts Outdated Show resolved Hide resolved
lib/modules/manager/types.ts Outdated Show resolved Hide resolved
@hasanwhitesource hasanwhitesource marked this pull request as draft May 9, 2022 07:46
@hasanwhitesource hasanwhitesource marked this pull request as ready for review May 9, 2022 10:37
lib/modules/manager/npm/types.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/update/dependency/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/update/dependency/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/update/dependency/index.ts Outdated Show resolved Hide resolved
@hasanwhitesource
Copy link
Contributor Author

@viceice looks good now ?🙂

@hasanwhitesource
Copy link
Contributor Author

@rarkins Any updates here ?

@rarkins rarkins enabled auto-merge (squash) May 17, 2022 14:57
@rarkins rarkins merged commit 4ef5aa2 into renovatebot:main May 17, 2022
@karlhorky
Copy link
Contributor

karlhorky commented May 17, 2022

@rarkins nice, thanks for the merge!

If I remember correctly, the bot will drop by as soon as this change is part of a new published version?

Edit: yep, there it is, great!

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.60.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@karlhorky
Copy link
Contributor

Just tested 32.60.0 and it's working!

It updated the "overrides" key in my package.json in this PR:

https://github.com/upleveled/changes-codealong/pull/85/files

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
@viceice viceice added regression Issue about a regression bug, or the PR caused it manager:npm package.json files (npm/yarn/pnpm) and removed regression Issue about a regression bug, or the PR caused it labels Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:npm package.json files (npm/yarn/pnpm)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for npm 8.3 Overrides
6 participants