New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(preset): group PHPStan packages together #15509
Conversation
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
just to make sure I'm not doing something here that the author is advising against - @ondrejmirtes do you also think it makes sense that renovate updates phpstan + extensions in the same PR by default or do you see reasons against that? I would also include 3rd party extensions or do you think we should avoid that? |
I don't understand. What's the current behaviour and what this PR change? PHPStan extension updates and PHPStan itself do not happen on the same schedule. There can be many extension updates between each PHPStan release, and some extension aren't update for months while PHPStan is updated many times. |
Ah sorry to drag you into this without much context. It would just group updates if possible basically. If there's only a phpstan update you get a dedicated PR, if there's only an extension update you also get a dedicated PR. But if there are multiple phpstan related updates, or you just wait long enough until there are, it would group them together in one PR. Update: sorry, hit save too soon. |
I'm not a Renovate expert to decide this. The way I got Renovate set up, all my updates are grouped for each |
But to me it seems weird to have an exception for PHPStan like that. It'd make sense to do this for all vendors (or none at all). |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
🎉 This PR is included in version 32.51.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Adds a new group preset that groups all PHPStan related packages together.
Context
PHPStan is one of the de-facto standard static analysis tools in the PHP ecosystem. It is developed at https://github.com/phpstan where also the default extensions are hosted in dedicated repos. There are also many third-party extensions like e.g. https://github.com/szepeviktor/phpstan-wordpress. Of course all packages are using Composer to correctly define the dependencies between them, but often you have to update
phpstan
first and e.g.phpstan-webmozart-assert
afterwards. Or you just update them together, which is why I thought this group might be helpful for others as well.Example package names:
phpstan/phpstan
,phpstan/phpstan-webmozart-assert
,szepeviktor/phpstan-wordpress
Or is use-case too specific to add it into renovate core presets?
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
Example run result