Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): extend module provider git url parsing #15773

Merged
merged 11 commits into from Jun 1, 2022
Merged

fix(terraform): extend module provider git url parsing #15773

merged 11 commits into from Jun 1, 2022

Conversation

MaronHatoum
Copy link
Contributor

Changes

fix gitTagsRefMatchRegex regex

Context

Closes #15467

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice changed the title Bug/terraform module provider unable to parse some git url fix(manager:terraform): module provider unable to parse some git url May 29, 2022
@MaronHatoum MaronHatoum requested a review from viceice May 30, 2022 05:34
@MaronHatoum
Merge branch 'main' of https://github.com/renovatebot/renovate into b…
5ed652a 
…ug/Terraform-module-provider-unable-to-parse-some-git-url
@MaronHatoum
bug: update
5a2ea2e
@MaronHatoum
Copy link
Contributor Author

can you please tell me if are any more changes needed here?

MaronHatoum and others added 3 commits May 31, 2022 09:01
@MaronHatoum @viceice
Update lib/modules/manager/terraform/modules.ts
7e4a8d8 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@MaronHatoum
bug: update
91ba16a
@MaronHatoum
Merge branch 'main' of https://github.com/renovatebot/renovate into b…
7aea99b 
…ug/Terraform-module-provider-unable-to-parse-some-git-url
@MaronHatoum MaronHatoum requested a review from viceice May 31, 2022 06:32
@MaronHatoum MaronHatoum requested a review from rarkins June 1, 2022 07:08
@rarkins rarkins changed the title fix(manager:terraform): module provider unable to parse some git url fix(terraform): extend module provider git url parsing Jun 1, 2022
@rarkins rarkins enabled auto-merge (squash) June 1, 2022 07:09
@rarkins rarkins merged commit 18b3c14 into renovatebot:main Jun 1, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.71.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@PhilipAbed PhilipAbed Awaiting requested review from PhilipAbed

@Gabriel-Ladzaretti Gabriel-Ladzaretti Awaiting requested review from Gabriel-Ladzaretti

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform-module provider unable to parse some git url
6 participants
@MaronHatoum @renovate-release @viceice @PhilipAbed @Gabriel-Ladzaretti @rarkins