New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Enable strict null checks for lookup-related functionality #15848
refactor: Enable strict null checks for lookup-related functionality #15848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some late feedback
@@ -145,6 +145,9 @@ export interface LookupUpdate { | |||
newVersion?: string; | |||
updateType?: UpdateType; | |||
userStrings?: Record<string, string>; | |||
checksumUrl?: string; | |||
downloadUrl?: string; | |||
releaseTimestamp?: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any
? really ? 😕
@@ -26,7 +26,7 @@ export async function filterInternalChecks( | |||
sortedReleases: Release[] | |||
): Promise<InternalChecksResult> { | |||
const { currentVersion, datasource, depName, internalChecksFilter } = config; | |||
let release: Release; | |||
let release: Release | undefined = undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let release: Release | undefined = undefined; | |
let release: Release | undefined; |
undefined is default value
🎉 This PR is included in version 32.71.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: