Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: additionalRegistryUrls #15868

Merged
merged 2 commits into from Jun 3, 2022
Merged

feat: additionalRegistryUrls #15868

merged 2 commits into from Jun 3, 2022

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jun 3, 2022

Changes

Refactors pip requirements extraction to return additionalRegistryUrls so that registryUrls do not need to be in ExtractConfig.

Context

ExtractConfig simplification.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice reviewed Jun 3, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/pip_requirements/extract.ts Show resolved Hide resolved
@rarkins rarkins enabled auto-merge (squash) June 3, 2022 06:33
@rarkins rarkins merged commit f5b8f08 into main Jun 3, 2022
@rarkins rarkins deleted the feat/additional-registry-urls branch June 3, 2022 06:46
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.72.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Churro Churro mentioned this pull request Jun 29, 2022
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@RahulGautamSingh RahulGautamSingh RahulGautamSingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rarkins @renovate-release @viceice @RahulGautamSingh