Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config migration PR title doesn't follow Conventional Commits spec #16364

Closed
Tracked by #16359
HonkingGoose opened this issue Jul 1, 2022 · 3 comments
Closed
Tracked by #16359
Labels
core:config Related to config capabilities and presets priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@HonkingGoose
Copy link
Collaborator

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

Please select which platform you are using if self-hosting.

No response

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Was this something which used to work for you, and then stopped?

I never saw this working

Describe the bug

Quote from #16355 (comment):

image

Example PR. Note that the PR title does not follow conventional commits although the commit message does - this needs to be fixed later.

We should probably fix this bug before we do:

Relevant debug logs

I don't have access to the logs.

Have you created a minimal reproduction repository?

No reproduction repository

@HonkingGoose HonkingGoose added type:bug Bug fix of existing functionality status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Jul 1, 2022
@HonkingGoose HonkingGoose changed the title Config migration PR title does not follow Coventional Commits Config migration PR title doesn't follow Conventional Commits spec Jul 1, 2022
@rarkins rarkins added core:config Related to config capabilities and presets priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:ready and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Jul 1, 2022
@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented Jul 6, 2022

Should it be hardcoded? ie. same for all migration PRs
Something like this:

const prTitle = `chore(config): migrate config ${filename}`;

Currently it's hardcoded this way:

  const prTitle = 'Migrate Renovate config';

@rarkins
Copy link
Collaborator

rarkins commented Jul 7, 2022

No, only if the repo is using conventional commits

@Gabriel-Ladzaretti
Copy link
Collaborator

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core:config Related to config capabilities and presets priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants