feat(gitlab-ci): ref add logic for updating non top level includes

[fredrondina]

Changes

Context

Current gitlab-ci ref bump logic only accounts for include sections that are at the top level of the .gitlab-ci.yml. This does not allows for the pipeline ref's contained within any subsection (such as within another job) of the .yml file to be updated. This pattern is commonly seen in .gitlab-cy.yml files used to configure parent child pipelines.

Closes #16833
Closes #9610

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[CLAassistant]

All committers have signed the CLA.

[a1flecke]

This is awesome. We really need this Gitlab CI ref support before we can use renovate in our enterprise

[rmacconn]

This would be awesome to be able to support Gitlab refs at all levels.

[fredrondina]

There seems to be a bug with the CLA status check, I have signed it and attached a screenshot showing this.

[a1flecke]

@astellingwerf @fredrondina any updates on when this will land?

[a1flecke]

@viceice, @astellingwerf, @secustor, @fredrondina Looks like this is coming along nicely. Do you think this will land this week?

[viceice]

we should probably merge both managers before this PR as planned for future

[a1flecke]

we should probably merge both managers before this PR as planned for future

Hey @viceice. Would it be possible to get this in first? My company is transitioning to Gitlab CI and wants to adopt renovate and move away from dependabot since dependabot does not support gitlab includes. We are using a lot of gitlab triggers that include refs. Renovate does not currently bump those refs since they are not top level. This is stopping us from launching renovate.

[viceice]

we should probably merge both managers before this PR as planned for future

Hey @viceice. Would it be possible to get this in first? My company is transitioning to Gitlab CI and wants to adopt renovate and move away from dependabot since dependabot does not support gitlab includes. We are using a lot of gitlab triggers that include refs. Renovate does not currently bump those refs since they are not top level. This is stopping us from launching renovate.

you need at least fix all requested changes

[fredrondina]

Requested changes have been made, ready for re-review

[a1flecke]

Any updates on this?

[a1flecke]

@viceice, @secustor , @astellingwerf , @rarkins , @fredrondina is this close? If not then we will need to launch Renovate with gitlab ci support turned off.

[fredrondina]

I am still having issues with the CLA check, I think it is due to some of my commits not being verified. What is the best step for me to take to get this last check passing?

[viceice]

probably squash or rebase your commits and fix author.

[fredrondina]

squashed and rebased in order to fix commit verification

[astellingwerf]

This is your chance to sneak something extra in, because I'm just gonna assume that the squashed commit is identical to the 25+ earlier commits combined.

[viceice]

nothing changed from gut perspective 👍

[fredrondina]

Any idea when this will be merged?

[astellingwerf]

That won't be until at least after the conflicts are resolved.

[fredrondina]

That won't be until at least after the conflicts are resolved.

Ok, can I rebase to fix the conflict, and then force push back to my branch?

[viceice]

no, please do merge commit with the fix

[fredrondina]

Merge conflicts resolved, ready for re-review

[renovate-release]

🎉 This PR is included in version 32.161.0 🎉

The release is available on:

• GitHub release
• 32.161.0

Your semantic-release bot 📦🚀