New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pip_requirements): ignore extras in test for hashes #16910
fix(pip_requirements): ignore extras in test for hashes #16910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks for the contribution!
# Conflicts: # lib/modules/manager/pip_requirements/artifacts.spec.ts
# Conflicts: # lib/modules/manager/pip_requirements/artifacts.ts
Head branch was pushed to by a user without write access
I added a test that brings the test line coverage back to 100%. Just as as side note (and maybe you are aware of this): The test |
🎉 This PR is included in version 32.165.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Make the check in the
pip_requirements
manager whether a line contains a dependency with hashes ignore any extras between the dependency name and the equal signs.Context
Closes #16869
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: