Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pip_requirements): ignore extras in test for hashes #16910

Merged

Conversation

chludwig-haufe
Copy link
Contributor

Changes

Make the check in the pip_requirements manager whether a line contains a dependency with hashes ignore any extras between the dependency name and the equal signs.

Context

Closes #16869

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins changed the title pip_requirements: ignore extras in test for hashes (Fix #16869) fix(pip_requirements): ignore extras in test for hashes Aug 2, 2022
Copy link
Collaborator

@PhilipAbed PhilipAbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the contribution!

lib/modules/manager/pip_requirements/artifacts.ts Outdated Show resolved Hide resolved
# Conflicts:
#	lib/modules/manager/pip_requirements/artifacts.spec.ts
PhilipAbed
PhilipAbed previously approved these changes Aug 8, 2022
@rarkins rarkins requested a review from viceice August 11, 2022 05:40
viceice
viceice previously approved these changes Aug 11, 2022
@viceice viceice enabled auto-merge (squash) August 11, 2022 05:56
auto-merge was automatically disabled August 19, 2022 10:55

Head branch was pushed to by a user without write access

@chludwig-haufe
Copy link
Contributor Author

I added a test that brings the test line coverage back to 100%.

Just as as side note (and maybe you are aware of this): The test util/git/index › commitFiles({branchName, files, message}) › updates git submodules kept failing on my machine (with the effect that the test coverage was always reported as < 100%) even though I had not touched any of the related files. In the end, I found the failure was somehow caused by the fact that I had a pre-commit hook configured in the git init templates. Once I moved the hook template aside, the test succeeded locally as well. I did not look further into it, but maybe it's worth mentioning in your local development docs that pre-commit templates can interfere with the tests.

@viceice viceice enabled auto-merge (squash) August 19, 2022 11:48
@viceice viceice merged commit 4322ae8 into renovatebot:main Aug 19, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.165.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip_requirements fails to update hashes on dependencies with extras
5 participants