refactor(repo/init): return additional raw config from detectRepoFileConfig #17021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
viceice
requested changes
Aug 6, 2022
…poFileConfig - revert caching
Gabriel-Ladzaretti
changed the title
|
reverted |
viceice
reviewed
Aug 10, 2022
Gabriel-Ladzaretti
force-pushed
the
memCache-detectRepoConfig
branch
from
9c7623a
to
c9a470e
Compare
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
|
learned something new, i pushed my changes but forgot to commit suggestions and suggestions got outdated which means they can't be commited. |
# Conflicts: # lib/workers/repository/init/merge.ts
rarkins
previously approved these changes
Aug 16, 2022
viceice
reviewed
Aug 16, 2022
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
This reverts commit 4275c39.
viceice
reviewed
Aug 16, 2022
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Gabriel-Ladzaretti
force-pushed
the
memCache-detectRepoConfig
branch
from
8f2a43d
to
073406f
Compare
# Conflicts: # lib/workers/repository/init/merge.spec.ts
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
approved these changes
Aug 18, 2022
|
you can find the blocking open discussion yourself 😛 |
|
🎉 This PR is included in version 32.165.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
detectRepoFileConfigwill now also return the raw config filerawConfigFileto theRepoFileConfigtype (return value ofdetectRepoFileConfig)cache (memCache) return values fordetectRepoFileConfigAs each repo has only one valid renovate config,
it might be beneficial to cache it.
detectRepoFileConfigis also used in the config migration flow and doing so will save some api/fs calls.once this is accepted, it can be utilized in order to resolve the following issue
The main problem with #16664 is the fact that we are trying to load a local copy of the config when the repo wasnt cloned.
detectRepoFileConfigdoes it already, so it can be cached and can be used instead.Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: