Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gomod): support .git indicator on private ee gitlab #17105

Merged
merged 2 commits into from Aug 17, 2022

Conversation

bastianccm
Copy link
Contributor

Changes

This change adds the behaviour from #13352 to private gitlab instances.

Context

Following up on #13352, gitlab installations which do not have a gitlab. URL prefix are not captured by the Regex in

/^(?<regExpUrl>gitlab\.[^/]*)\/(?<regExpPath>.+?)(?:\/v\d+)?[/]?$/

This change adds the same behaviour for repositories which set a Gitlab host-rule, which indicates that we are dealing with Gitlab.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously approved these changes Aug 12, 2022
nabeelsaabna
nabeelsaabna previously approved these changes Aug 12, 2022
lib/modules/datasource/go/base.ts Outdated Show resolved Hide resolved
lib/modules/datasource/go/base.ts Outdated Show resolved Hide resolved
@viceice viceice enabled auto-merge (squash) August 17, 2022 05:28
@viceice viceice merged commit 2bfe93a into renovatebot:main Aug 17, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.161.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bastianccm bastianccm deleted the go-private-vcs-subgroup branch August 17, 2022 07:03
@rarkins rarkins added the regression Issue about a regression bug, or the PR caused it label Sep 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
regression Issue about a regression bug, or the PR caused it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants