Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gradle-wrapper): support for wrapper updates in sub-directory #17164

Merged
merged 10 commits into from Aug 18, 2022
Merged

fix(gradle-wrapper): support for wrapper updates in sub-directory #17164

merged 10 commits into from Aug 18, 2022

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Aug 13, 2022 •
edited

Changes

  • Adds support for gradle-wrapper updates, if gradle-wrapper is located in a sub-directory
  • Updates distributionSha256Sum and, if the gradle build runs through successfully, wrapper artifacts too

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Churro Churro marked this pull request as draft August 13, 2022 13:04
viceice
viceice requested changes Aug 13, 2022
View reviewed changes
lib/modules/manager/gradle-wrapper/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/gradle-wrapper/utils.ts Outdated Show resolved Hide resolved
lib/modules/manager/gradle-wrapper/artifacts.ts Outdated Show resolved Hide resolved
@Churro Churro marked this pull request as ready for review August 13, 2022 15:23
@Churro Churro requested a review from viceice August 15, 2022 09:38
@viceice viceice mentioned this pull request Aug 16, 2022
Merged
6 tasks
viceice
viceice requested changes Aug 16, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viceice
Copy link
Member

viceice commented Aug 16, 2022

needs deconflicting now 👼

@viceice viceice marked this pull request as draft August 16, 2022 07:15
@Churro
Merge remote-tracking branch 'upstream/main' into gradle-wrapper
6636363 
# Conflicts:
#	lib/modules/manager/gradle-wrapper/artifacts.spec.ts
#	lib/modules/manager/gradle-wrapper/artifacts.ts
#	lib/modules/manager/gradle-wrapper/utils.ts
@Churro
redo the whole thing
ed34318
@Churro Churro marked this pull request as ready for review August 16, 2022 20:44
@Churro Churro requested a review from viceice August 16, 2022 20:44
@viceice viceice enabled auto-merge (squash) August 17, 2022 13:53
@viceice viceice merged commit b8004fe into renovatebot:main Aug 18, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.163.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MaronHatoum MaronHatoum mentioned this pull request Aug 18, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Churro @viceice @renovate-release @rarkins