Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(presets): handle null values from azure #17236

Merged
merged 2 commits into from Aug 17, 2022
Merged

fix(presets): handle null values from azure #17236

merged 2 commits into from Aug 17, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Aug 17, 2022

Changes

  • handle missing repoId at azure
  • handle null presets

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins August 17, 2022 13:11
@JamieMagee
Copy link
Contributor

I am not sure this fixes organization presets for Azure DevOps, but it absolutely fixes the symptom of incorrect presets.

@rarkins rarkins enabled auto-merge (squash) August 17, 2022 15:51
@rarkins rarkins merged commit 2525f71 into main Aug 17, 2022
@rarkins rarkins deleted the fix/presets/azure branch August 17, 2022 15:52
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.162.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice viceice added the regression Issue about a regression bug, or the PR caused it label Aug 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
regression Issue about a regression bug, or the PR caused it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renovate adds Organisation Preset Repository when onboarding, even if it not exists
4 participants
@viceice @JamieMagee @renovate-release @rarkins