New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace fast-safe-stringify
with safe-stable-stringify
#17251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i though we also replace the existing package
The other package is used at one place only and I am not sure what it is used for my guess is sorting config as well: Line 4 in ab94b95
If we can achieve the same with this package then the exhange is possible; |
should work, but we probably need to disable key sorting there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used the fast-safe-stringify package because JSON.stringify() hit circular references sometimes, somehow.
If this replacement reorders objects and is used anywhere we process config then it can reorder config in a problematic way
We can configure the
https://github.com/BridgeAR/safe-stable-stringify#stringifyconfigureoptions |
null for circular is ok |
the old |
fast-safe-stringify
with safe-stable-stringify
🎉 This PR is included in version 32.166.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
safe-stable-stringify
packageContext
Documentation (please check one with an [x])