Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): filter deps with skip reason #17256

Merged
merged 2 commits into from
Aug 18, 2022
Merged

fix(dashboard): filter deps with skip reason #17256

merged 2 commits into from
Aug 18, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Aug 18, 2022

Changes

  • filter all deps with skipReason
  • simplify code

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Gabriel-Ladzaretti
Gabriel-Ladzaretti reviewed Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@Gabriel-Ladzaretti Gabriel-Ladzaretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise no other input 😀

lib/workers/repository/package-files.ts Show resolved Hide resolved
Gabriel-Ladzaretti
Gabriel-Ladzaretti approved these changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@Gabriel-Ladzaretti Gabriel-Ladzaretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from below nit, LGTM

lib/workers/repository/package-files.ts Show resolved Hide resolved
rarkins
rarkins approved these changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy if you two are happy

@viceice viceice enabled auto-merge (squash) August 18, 2022 18:41
@viceice viceice merged commit 709c790 into main Aug 18, 2022
@viceice viceice deleted the fix/dashboard/invalid-deps branch August 18, 2022 18:52
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.165.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gabriel-Ladzaretti Gabriel-Ladzaretti Gabriel-Ladzaretti approved these changes

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid deps are shown on dashboard detected dependencies
4 participants
@viceice @renovate-release @rarkins @Gabriel-Ladzaretti