Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets/replacements): add now-to-vercel replacement #17293

Merged
merged 1 commit into from Aug 20, 2022

Conversation

JamieMagee
Copy link
Contributor

Changes

Adds a replacement to rename now1 to vercel2

Context

Both now and vercel were published together, with the same version, from 19.0.0 to 21.0.1. From 21.1.0 only vercel was published.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Footnotes

  1. https://www.npmjs.com/package/now

  2. https://www.npmjs.com/package/vercel

@viceice viceice merged commit 844887a into main Aug 20, 2022
@viceice viceice deleted the feat/now-vercel-replacement branch August 20, 2022 05:18
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.168.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose
Copy link
Collaborator

Hi @JamieMagee 👋

The now-to-vercel preset is not listed in the "All replacements" section as replacements:now-to-vercel. Is that what you meant to do? I think we usually add the new preset to the replacements:all preset as well?

Here's the code I'm talking about:

all: {
description: 'All replacements.',
extends: [
'replacements:babel-eslint-to-eslint-parser',
'replacements:cucumber-to-scoped',
'replacements:hapi-to-scoped',
'replacements:jade-to-pug',
'replacements:joi-to-scoped',
'replacements:joi-to-unscoped',
'replacements:renovate-pep440-to-renovatebot-pep440',
'replacements:rollup-node-resolve-to-scoped',
'replacements:xmldom-to-scoped',
],
},

'now-to-vercel': {
description: '`now` was renamed to `vercel`.',
packageRules: [
{
matchCurrentVersion: '>=21.0.0',
matchDatasources: ['npm'],
matchPackageNames: ['now'],
replacementName: 'vercel',
replacementVersion: '21.0.0',
},
],
},

@JamieMagee
Copy link
Contributor Author

@HonkingGoose Good catch! I totally forgot to do that 🤦 Can you add it as part of #17279 please?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants