All non-major group now containing Docker tags suffix

[setchy]

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

Please select which platform you are using if self-hosting.

No response

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Was this something which used to work for you, and then stopped?

It used to work, and then stopped

Describe the bug

In the last few days I've noticed a number of our non-major dependency PRs now containing a suffix of Docker tags which I haven't noticed before.

I've created a minimal reproduction repository here - https://github.com/setchy/renovate-minor-group-name/pull/1

Of note is this PR contains both a Dockerfile and pom.xml update, yet has the Docker tags string appended to the group name

I'm not sure if there is any correlation with moving to the renovate:slim image and using RENOVATE_BINARY_SOURCE=install

Relevant debug logs

Logs

Copy/paste the relevant log(s) here, between the starting and ending backticks

Have you created a minimal reproduction repository?

I have linked to a minimal reproduction repository in the bug description

[setchy]

Update: just tested with a self-hosted configuration using the docker image renovate/renovate and RENOVATE_BINARY_SOURCE=global and the PR name remains the same

[viceice]

This is caused by #17102, which fixed a bug where the docker datasource defauzlt config was never applied. So this is an expected behavior to me.

So you would need to override commitMessageTopic for your group. 🤔

@rarkins WDYT?

---

renovate/lib/modules/datasource/docker/index.ts

Lines 343 to 368 in d19b708

	const defaultConfig = {
	commitMessageTopic: '{{{depName}}} Docker tag',
	commitMessageExtra:
	'to {{#if isMajor}}{{{prettyNewMajor}}}{{else}}{{{prettyNewVersion}}}{{/if}}',
	digest: {
	branchTopic: '{{{depNameSanitized}}}-{{{currentValue}}}',
	commitMessageExtra: 'to {{newDigestShort}}',
	commitMessageTopic:
	'{{{depName}}}{{#if currentValue}}:{{{currentValue}}}{{/if}} Docker digest',
	group: {
	commitMessageTopic: '{{{groupName}}}',
	commitMessageExtra: '',
	},
	},
	pin: {
	commitMessageExtra: '',
	groupName: 'Docker digests',
	group: {
	commitMessageTopic: '{{{groupName}}}',
	branchTopic: 'digests-pin',
	},
	},
	group: {
	commitMessageTopic: '{{{groupName}}} Docker tags',
	},
	};

[viceice]

maybe we should update group:allNonMajor preset to override commitMessageTopic ? 🤔

[setchy]

maybe we should update group:allNonMajor preset to override commitMessageTopic ? 🤔

ah, so it's lines 365 to 367 thats introduced this new commit message.

Could that be removed and just rely on the groupName? I'd imagine similar outcomes would happen for many of the other group presets, not just group:allNonMajor

[rarkins]

The only other place we've specified commitMessageTopic for group is in Helm, and that was probably copied from Docker. I think it may be easier to remove those lines.

[setchy]

#17381

[renovate-release]

🎉 This issue has been resolved in version 32.174.1 🎉

The release is available on:

• GitHub release
• 32.174.1

Your semantic-release bot 📦🚀