Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replacement for pep440 versioning #17882

Merged

Conversation

t-kulmburg
Copy link
Contributor

As requested I am splitting my replacement pr #17476.
This pr makes sure the correct replacementName and replacementVersion are used, as some dependencies didn't get replacements.
It also fixes a problem I encountered with pep440, where now the rangeStrategy handling is skipped when the update is a replacement (used to throw an exception and therefore didn't replace the value).

@t-kulmburg t-kulmburg changed the title feat: add replacement split: lookup/versioning changes feat: replacement split: lookup/versioning changes Sep 20, 2022
@JamieMagee JamieMagee self-requested a review September 27, 2022 04:30
Copy link
Contributor

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add any new tests?

@t-kulmburg
Copy link
Contributor Author

Any updates here? @JamieMagee

@viceice viceice requested a review from rarkins November 9, 2022 08:27
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should prbably also be split into 2 PR's:

  1. feat: support replacement for pep440
  2. fix: use correct values for replacements

@JamieMagee
Copy link
Contributor

If you hit this issue with pep440 versioning, do you think might need this for other versioning schemes that support replacement range strategies?

JamieMagee
JamieMagee previously approved these changes Nov 14, 2022
Copy link
Contributor

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs deconflicting, and potentially a follow-up issue for other versioning schemes, but otherwise looks good to go!

@t-kulmburg t-kulmburg changed the title feat: replacement split: lookup/versioning changes fix: replacement for pep440 versioning Nov 14, 2022
@t-kulmburg
Copy link
Contributor Author

I did not encounter any problems like this with the other managers/datasources I tested, they are listed here in my README. For the pep440 datasource however there is an Error in versioning/pep440/handleReplaceStrategy, which is fixed/avoided by this PR.
Of course I cannot guarantee that no other problems could pop up, as I only tested one replacement per Manager.

@t-kulmburg t-kulmburg requested review from JamieMagee and removed request for rarkins November 14, 2022 10:33
@JamieMagee JamieMagee enabled auto-merge (squash) November 14, 2022 19:02
@JamieMagee JamieMagee merged commit 7f3fa10 into renovatebot:main Nov 14, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.24.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants