Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag config options in code to show "for advanced users only" admonition #18408

Closed
3 tasks done
HonkingGoose opened this issue Oct 19, 2022 · 6 comments · Fixed by #18505
Closed
3 tasks done

Flag config options in code to show "for advanced users only" admonition #18408

HonkingGoose opened this issue Oct 19, 2022 · 6 comments · Fixed by #18505
Assignees
Labels
priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:feature Feature (new functionality)

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Oct 19, 2022

What would you like Renovate to be able to do?

Right now, we have to put an admonition in the docs to tell users that a config option is "for advanced users only".

@rarkins had the idea of automating this, like we do already for experimental config options.

If you have any ideas on how this should be implemented, please tell us here.

  • Create new config option Boolean called advancedUse that we can attach to config options in the code
  • Write code that can create the warning admonition for us.
  • After the PR lands that makes the code and admonition work: remove the old manual "for advanced users" admonitions from the docs

How it should work:

  • If advancedUse=true then our docs build process adds the admonition to the docs
  • If advancedUse=false then nothing happens.

Related comment:

Is this a feature you are interested in implementing yourself?

No

@HonkingGoose HonkingGoose added type:feature Feature (new functionality) status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Oct 19, 2022
@rarkins
Copy link
Collaborator

rarkins commented Oct 19, 2022

I think we can shorten it to an advancedUse boolean

@rarkins rarkins added status:ready priority-2-high Bugs impacting wide number of users or very important features and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Oct 19, 2022
@secustor
Copy link
Collaborator

How is it planned to notify the users?
A log message is pretty obvious, but what is about users without access to the logs?

I propose following:

  • Add a warning to the dashboard
  • create repository config option to acknowledge these warnings, which will then remove them again.

@betterPeleg
Copy link
Contributor

@HonkingGoose
can you please share the current admonition added to the docs manually?

@HonkingGoose
Copy link
Collaborator Author

HonkingGoose commented Oct 19, 2022

can you please share the current admonition added to the docs manually?

@betterPeleg Here's your Markdown: 😉

<!-- prettier-ignore -->
!!! warning
    Warning, for advanced use only! Use at your own risk!

Edit: I think this is better though:

<!-- prettier-ignore -->
!!! warning
    For advanced use only! Use at your own risk!

The admonition text itself already displays "Warning" as title, so we don't need it again in the body text. 😉


How is it planned to notify the users?
A log message is pretty obvious, but what is about users without access to the logs?

@secustor I'm sorry for confusing you. We plan to notify the users via the docs. I don't know if adding a log WARN message is something we want. I'll let @rarkins decide. 😉

I propose following:

* Add a warning to the dashboard

* create repository config option to acknowledge these warnings, which will then remove them again.

I don't like this idea for "advanced users only warnings" in the Dependency Dashboard. It may work somewhat OK for "deprecated" config options. But we're planning to migrate a users' outdated config with a Renovate PR automatically. Once that feature lands we don't need a Dependency Dashboard notification:

@secustor
Copy link
Collaborator

@HonkingGoose Oh, gotcha!

@rarkins
Copy link
Collaborator

rarkins commented Oct 19, 2022

I think a docs-only warning message is ok. We don't to want to warn advanced users non-stop e.g. in Dashboard

@HonkingGoose HonkingGoose added status:in-progress Someone is working on implementation and removed status:ready labels Oct 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants