Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): add mono repo shedlock #18823

Merged
merged 3 commits into from Nov 17, 2022
Merged

Conversation

boretti
Copy link
Contributor

@boretti boretti commented Nov 8, 2022

Changes

Add shedLock (https://github.com/lukas-krecan/ShedLock) to the grouped package in default preset.

Context

The shedLock java package should be grouped.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@boretti
Copy link
Contributor Author

boretti commented Nov 8, 2022

Related issues #18822

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we group with source url instead? like we do for other monorepos? checkout the monorepo.ts

that packages need to publish the source url inside the pom files.

@boretti
Copy link
Contributor Author

boretti commented Nov 16, 2022

Hello. I agree, it would be better to use the mono repo feature. I will update the MR.

@boretti
Copy link
Contributor Author

boretti commented Nov 16, 2022

The following configuration was tested on a self hosted renovate :

"packageRules": [
      {
        "groupName": "shedlock monorepo",
        "matchSourceUrlPrefixes":["https://github.com/lukas-krecan/ShedLock"]
      }
]

which should be similar to the one produced by the monorepo.js file

@boretti boretti changed the title Update group.ts feat: add mono repo shedlock Nov 16, 2022
@rarkins rarkins changed the title feat: add mono repo shedlock feat(presets): add mono repo shedlock Nov 17, 2022
@rarkins rarkins enabled auto-merge (squash) November 17, 2022 05:43
@rarkins rarkins merged commit de921cc into renovatebot:main Nov 17, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@boretti boretti deleted the addShedLock branch November 17, 2022 07:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shedLock (https://github.com/lukas-krecan/ShedLock) to the grouped package
4 participants