fix: make replacementName and Version not mergeable #18853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changes the config options
replacementName
andreplacementVersion
to be not mergeable.Both are Strings that are used in package files exactly as they are written in the config, so merging them (in this case would mean appending two strings) does not make sense.
Context
This fixes this requested change in my other pull request, meaning i don`t need to make the change in the link at all.
Reason for this change is that I encountered a problem when working on replacements (#17882 & #17883):
Inside mergeChildConfig, when merging both replacementName and replacementVersion (both merging configs already had the same entries for both) the entry changed to an Array of single characters.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: