Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): Use codeBlock tagged literal #18916

Merged
merged 6 commits into from Nov 15, 2022

Conversation

zharinov
Copy link
Collaborator

Changes

  • Nice indenting of code fragments used in tests
  • Indenting level infromation doesn't leak to the code fragment
  • Describing code blocks near the place where it's being used is safer

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice previously approved these changes Nov 14, 2022
rarkins
rarkins previously approved these changes Nov 14, 2022
@rarkins rarkins enabled auto-merge (squash) November 14, 2022 19:26
@viceice
Copy link
Member

viceice commented Nov 15, 2022

it seems we've some test issues1 in mint manager
image

Footnotes

  1. https://app.codecov.io/gh/renovatebot/renovate/pull/18916

@viceice viceice dismissed stale reviews from rarkins and themself via 3d9cee1 November 15, 2022 08:16
@rarkins rarkins merged commit 3c56aec into renovatebot:main Nov 15, 2022
@rarkins rarkins deleted the refactor/code-block-tagged-literal branch November 15, 2022 08:35
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants