Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(manager/gradle): add further tests #18977

Merged
merged 1 commit into from Nov 18, 2022

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Nov 17, 2022

Changes

Increases coverage and adds further tests for the Gradle parser. This includes negative matches, warranted, e.g., by setting maxDepth: 1 in the implementation, and additional tests that are matched due to the reuse of query patterns.

The removal of fs.readLocalFile.mockImplementation(...) is unrelated and an oversight of PR #18931

Context

PR #18663 introduced a new parser implementations that is more flexible with regards to pattern combinations. Hence, it needs be ensured that future changes to the implementation won't inadvertently change what is currently matched.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins merged commit ff96c5f into renovatebot:main Nov 18, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.27.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants