Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): use nvmrc from lock file dir #18978

Merged
merged 2 commits into from Nov 18, 2022
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Nov 18, 2022

Changes

Use the lock file dir to find .nvmrc instead of the package file dir

Context

Closes #18885

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice November 18, 2022 05:30
@viceice viceice enabled auto-merge (squash) November 18, 2022 05:55
@viceice viceice merged commit d1d6feb into main Nov 18, 2022
@viceice viceice deleted the fix/18885-nvmrc-subfolder branch November 18, 2022 06:13
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.27.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to pick up right Node.js version in sub folder
3 participants