Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): use HCL parser and introduce class based extractors #19269

Merged
merged 12 commits into from Jan 9, 2023
Merged

feat(terraform): use HCL parser and introduce class based extractors #19269

merged 12 commits into from Jan 9, 2023

Conversation

secustor
Copy link
Collaborator

@secustor secustor commented Dec 5, 2022 •
edited

Changes

This change is a follow up to #14262

Changes include:

  • use HCL parser
  • introduce class based "Extractors"
  • generic HCL docker image extractor. This could be a basis for a later HCL custom manager

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor requested a review from viceice December 6, 2022 10:50
viceice
viceice requested changes Dec 8, 2022
View reviewed changes
lib/modules/manager/terraform/extractors.ts Outdated Show resolved Hide resolved
lib/modules/manager/terraform/extractors.ts Outdated Show resolved Hide resolved
lib/modules/manager/terraform/extractors/others/modules.ts Outdated Show resolved Hide resolved
lib/modules/manager/terraform/extractors/others/modules.ts Show resolved Hide resolved
lib/modules/manager/terraform/base.ts Outdated Show resolved Hide resolved
lib/modules/manager/terraform/base.ts Show resolved Hide resolved
lib/modules/manager/terraform/extractors/terraform-block/terraform-version.ts Outdated Show resolved Hide resolved
lib/modules/manager/terraform/extractors/resources/utils.ts Show resolved Hide resolved
lib/modules/manager/terraform/extractors/resources/generic-docker-image-ref.ts Outdated Show resolved Hide resolved
lib/modules/manager/terraform/extract.ts Outdated Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented Dec 8, 2022

nice work so far. we should add typings for parsed hcl in a later PR to be more safe

@secustor secustor requested a review from viceice December 8, 2022 17:29
viceice
viceice reviewed Dec 9, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/terraform/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/terraform/extractors/terraform-block/terraform-version.ts Show resolved Hide resolved
@secustor secustor mentioned this pull request Dec 13, 2022
Closed
@secustor @HonkingGoose
Update lib/modules/manager/terraform/base.ts
450d309 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
viceice
viceice reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@secustor secustor requested a review from viceice January 9, 2023 12:52
@viceice viceice changed the title refactor(terraform): use HCL parser and introduce class based extractors feat(terraform): use HCL parser and introduce class based extractors Jan 9, 2023
@viceice
Copy link
Member

viceice commented Jan 9, 2023

merging as feature, as it makes big changes and i wan't to have a release now for it.

@viceice viceice enabled auto-merge (squash) January 9, 2023 12:58
@viceice viceice merged commit 1ab049f into renovatebot:main Jan 9, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.95.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@secustor secustor mentioned this pull request Jan 13, 2023
Merged
6 tasks
@rarkins rarkins mentioned this pull request Jan 13, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose left review comments

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@secustor @viceice @renovate-release @HonkingGoose