Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(presets/regex): Add preset for appVersion in helm charts #19371

Merged
merged 10 commits into from Jan 16, 2023
Merged

feat(presets/regex): Add preset for appVersion in helm charts #19371

merged 10 commits into from Jan 16, 2023

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Dec 13, 2022 •
edited

Changes

Adds a new regex preset for appVersion in Chart.yaml

Context

See #13968

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@jkroepke jkroepke changed the title Add preset for appVersion in helm charts feat: Add preset for appVersion in helm charts Dec 13, 2022
@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Dec 14, 2022 •
edited

Hi @jkroepke,

Thank you for applying my suggestion. 😄

Next time, please don't force push to your pull request branch. Here's why: 1

Do not force push to your pull request branch

Please do not force push to your PR's branch after you have created your PR, as doing so forces us to review the whole PR again. This makes it harder for us to review your work because we don't know what has changed. PRs will always be squashed by us when we merge your work. Commit as many times as you need in your pull request branch.

If you are updating your PR branch from within the GitHub PR interface, then only use the default "Update branch" button.

Force pushing a PR is OK when:

  • you need to make large changes on a PR which require a full review anyway
  • you need to bring the branch up-to-date with the target branch and incorporating the changes is more work than to create a new PR

Footnotes

  1. Renovate's contributing guide ↩

@rarkins
Copy link
Collaborator

rarkins commented Dec 15, 2022

Is it possible to supplement this with an example in https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/regex/readme.md which references this preset?

@jkroepke
Copy link
Contributor Author

Is it possible to supplement this with an example in main/lib/modules/manager/regex/readme.md which references this preset?

Not sure, if its worth. Added.

HonkingGoose
HonkingGoose suggested changes Dec 21, 2022
View reviewed changes
lib/config/presets/internal/regex-managers.ts Outdated Show resolved Hide resolved
lib/modules/manager/regex/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/regex/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/regex/readme.md Outdated Show resolved Hide resolved
jkroepke and others added 2 commits January 4, 2023 09:17
@jkroepke @HonkingGoose @secustor
Apply suggestions from code review
9928b3d 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@jkroepke
Merge branch 'main' into patch-1
870489a
@jkroepke jkroepke requested review from HonkingGoose and secustor and removed request for HonkingGoose January 4, 2023 08:17
@jkroepke
Copy link
Contributor Author

jkroepke commented Jan 4, 2023

Thanks for the reviews

@rarkins rarkins enabled auto-merge (squash) January 4, 2023 08:35
@jkroepke @viceice
Update lib/config/presets/internal/regex-managers.ts
98c9a0d 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
auto-merge was automatically disabled January 15, 2023 22:54

Head branch was pushed to by a user without write access

@rarkins rarkins requested a review from viceice January 16, 2023 09:17
@viceice viceice changed the title feat: Add preset for appVersion in helm charts feat(presets/regex): Add preset for appVersion in helm charts Jan 16, 2023
@rarkins rarkins enabled auto-merge (squash) January 16, 2023 09:53
@rarkins rarkins merged commit 2c70a5d into renovatebot:main Jan 16, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.103.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose requested changes

@viceice viceice viceice approved these changes

@secustor secustor secustor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jkroepke @CLAassistant @HonkingGoose @rarkins @renovate-release @viceice @secustor