fix(platform/gitlab): Strip unicode null characters from markdown #19664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to post a comment with null characters in them fails with a 400 error. See renovatebot#19532 for more details.
nfm
changed the title
nfm
changed the title
viceice
reviewed
Jan 4, 2023
viceice
previously approved these changes
Jan 5, 2023
viceice
changed the title
viceice
reviewed
Jan 5, 2023
auto-merge was automatically disabled
January 5, 2023 22:56
Head branch was pushed to by a user without write access
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
previously approved these changes
Jan 6, 2023
viceice
reviewed
Jan 6, 2023
The mocks appear not to be isolated properly between tests, and having a test that mocks this before a test that does not causes the latter to fail.
viceice
approved these changes
Jan 11, 2023
rarkins
approved these changes
Jan 11, 2023
|
🎉 This PR is included in version 34.98.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to post a comment with null characters in them fails with a 400 error. See #19532 for more details.
Changes
Strip unicode null characters from GitLab markdown, as their presence prevents comments from being posted. bundler appears to generate some error messages that include them.
Context
#19532
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: