fix(versioning/hashicorp): check valid before matches #19742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
approved these changes
Jan 9, 2023
viceice
reviewed
Jan 9, 2023
| return false; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| function matches(version: string, range: string): boolean { | ||
| return npm.matches(version, hashicorp2npm(range)); | ||
| return isValid(range) && npm.matches(version, hashicorp2npm(range)); |
There was a problem hiding this comment.
are we doing this at other versionings too? 🤔
There was a problem hiding this comment.
we don't seem to have the same problem with others, maybe because they don't throw
There was a problem hiding this comment.
I nearly added this here, but thought, its probably called before matches is called, as none of the other versioning do this
|
🎉 This PR is included in version 34.95.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Closes #19739
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: