Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): add Algolia InstantSearch monorepo #19761

Merged
merged 1 commit into from Jan 10, 2023

Conversation

zacharyliu
Copy link
Contributor

Changes

Add the Algolia InstantSearch monorepo to the list of monorepo presets.

Context

Algolia recently merged their React InstantSearch monorepo into their main InstantSearch monorepo:
https://github.com/algolia/react-instantsearch#react-instantsearch-has-a-new-home-

This project has moved and is now part of the InstantSearch monorepo! The library remains unchanged and is still available on npm and CDNs like jsDelivr.

This broke the existing algolia-react-instantsearch config and caused packages like react-instantsearch-hooks-server and react-instantsearch-hooks-web to get submitted as separate update PRs with broken peer dependencies.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

I'm assuming this will be picked up in the documentation automatically since I don't see any places the other configs are mentioned?

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice changed the title Add Algolia InstantSearch monorepo feat(presets): add Algolia InstantSearch monorepo Jan 10, 2023
@viceice viceice enabled auto-merge (squash) January 10, 2023 01:00
@viceice viceice merged commit fc41de3 into renovatebot:main Jan 10, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.97.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zacharyliu
Copy link
Contributor Author

Ah, sorry, I just did some additional testing and realized that the NPM packages actually point to https://github.com/algolia/instantsearch.js, which redirects to https://github.com/algolia/instantsearch, but is treated differently by Renovate. Using the .js version in our repo does work with a local Renovate config. I'll submit a followup fix to add both in case they change this in the future.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants