Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/docker): Validate digest value before calling API #19780

Merged

Conversation

zharinov
Copy link
Collaborator

Changes

Without validation, someone can type wrong hash and we'll end up with ExternalHostError causing to stop the entire run.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice changed the title fix(docker): Validate digest value before calling API fix(datasource/docker): Validate digest value before calling API Jan 11, 2023
@zharinov zharinov requested a review from rarkins January 11, 2023 13:19
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/util/string.ts Show resolved Hide resolved
@zharinov zharinov requested a review from viceice January 13, 2023 05:31
@viceice viceice merged commit b00294f into renovatebot:main Jan 13, 2023
@viceice viceice deleted the fix/docker-datasource-validate-digests branch January 13, 2023 05:54
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.100.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants