Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(poetry): Fix existing range unions #19785

Merged

Conversation

nphilipp
Copy link
Contributor

Previously, the call to .replace() only ever affected the first occurrence of "||" in the string. This makes the regex global to remove all spurious commas.

Fixes: #18130

Signed-off-by: Nils Philippsen nils@redhat.com

Changes

Widening Python version range unions adds syntactically incorrect commas, this change fixes it and adds a test.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Previously, the call to .replace() only ever affected the first
occurrence of "||" in the string. This makes the regex global to remove
all spurious commas.

Fixes: renovatebot#18130

Signed-off-by: Nils Philippsen <nils@redhat.com>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rarkins rarkins merged commit 1991b7f into renovatebot:main Jan 11, 2023
@rarkins
Copy link
Collaborator

rarkins commented Jan 11, 2023

@nphilipp Thanks for your patience and PR. If you can find out if there's anything particular about this CLA that's problematic, please let me know

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.99.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nphilipp nphilipp deleted the main--poetry-fix-version-transform branch January 11, 2023 17:02
@nphilipp
Copy link
Contributor Author

@nphilipp Thanks for your patience and PR. If you can find out if there's anything particular about this CLA that's problematic, please let me know

No worries, the blame for the delay lies entirely on my end 😉. I'll get in touch with our legal team and, if it's alright with you, will try to establish a contact between you and them.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry version widen broken with multiple existing range unions
4 participants