Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(templates): try/catch handlebars compile #19794

Merged
merged 6 commits into from Jan 14, 2023
Merged

fix(templates): try/catch handlebars compile #19794

merged 6 commits into from Jan 14, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jan 11, 2023 •
edited

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice January 11, 2023 16:42
rarkins
rarkins commented Jan 11, 2023
View reviewed changes
lib/util/template/index.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Jan 12, 2023
View reviewed changes
lib/util/template/index.ts Outdated Show resolved Hide resolved
@rarkins
Copy link
Collaborator Author

rarkins commented Jan 14, 2023

It seems some users of template.compile() rely on it throwing for invalid, so I've made a small change just to satisfy a problem I'm seeing in problem. We can expand safeCompile use over time

@rarkins rarkins requested a review from viceice January 14, 2023 06:39
viceice
viceice reviewed Jan 14, 2023
View reviewed changes
lib/util/template/index.ts Outdated Show resolved Hide resolved
@rarkins @viceice
Update lib/util/template/index.ts
ff800c3 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins requested a review from viceice January 14, 2023 07:33
@rarkins rarkins enabled auto-merge (squash) January 14, 2023 07:33
@rarkins rarkins merged commit 98247d3 into main Jan 14, 2023
@rarkins rarkins deleted the fix/template-catch branch January 14, 2023 08:35
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.102.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rarkins @renovate-release @viceice