Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/pub): update to only changed dependencies #19825

Merged
merged 5 commits into from Jan 20, 2023
Merged

feat(manager/pub): update to only changed dependencies #19825

merged 5 commits into from Jan 20, 2023

Conversation

zeshuaro
Copy link
Contributor

@zeshuaro zeshuaro commented Jan 13, 2023

Changes

  • Update to specify the updated dependencies for the pub manager when we attempt to lock their versions with pub upgrade
  • Add more logging when updating the lock file
  • I loosely referenced the code from the poetry manager

Context

Closes #19653

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
    • See this PR for the current behaviour, where transitive dependency in the lock file is updated as part of the main dependency update
    • See this PR for the new behaviour where the transitive dependency is not updated, only the main dependency is

@JamieMagee
Copy link
Contributor

Does pub upgrade with a specific dependency also handle indirect dependencies? For example, if I depend on A, and A depends on B, does pub upgrade A also upgrade B when required?

@zeshuaro
Copy link
Contributor Author

Does pub upgrade with a specific dependency also handle indirect dependencies? For example, if I depend on A, and A depends on B, does pub upgrade A also upgrade B when required?

Yes it does, see this PR for example: barriot/r2#12

Co-authored-by: Jamie Magee <jamie.magee@gmail.com>
@zeshuaro zeshuaro requested review from JamieMagee and removed request for viceice January 19, 2023 07:03
lib/modules/manager/pub/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pub/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pub/artifacts.ts Outdated Show resolved Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@zeshuaro zeshuaro requested review from viceice and removed request for JamieMagee January 19, 2023 07:29
@viceice viceice changed the title fix(pub): update to only lock updated dependencies feat(manager/pub): update to only changed dependencies Jan 19, 2023
@rarkins rarkins enabled auto-merge (squash) January 20, 2023 06:08
@rarkins rarkins merged commit 6be73f1 into renovatebot:main Jan 20, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.107.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zeshuaro zeshuaro deleted the fix/pub-upgrade-lockfile branch January 20, 2023 07:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep changes in pubspec.lock to minimum
5 participants