Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versioning/hashicorp): allow v versions from npm #19841

Merged
merged 1 commit into from Jan 14, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jan 14, 2023

Changes

Allows v versions instead of throwing

Context

Errors thrown in the hosted app

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice January 14, 2023 08:25
@rarkins
Copy link
Collaborator Author

rarkins commented Jan 14, 2023

@mcfedr I'm not sure if this is the best way to fix this, but at least it should stop it throwing for values like v4.0.1

@rarkins
Copy link
Collaborator Author

rarkins commented Jan 14, 2023

This may fix #19766 if the original fix didn't

@rarkins rarkins merged commit 3a6cfac into main Jan 14, 2023
@rarkins rarkins deleted the fix/hashicorp-versioning-v branch January 14, 2023 08:52
@mcfedr
Copy link
Contributor

mcfedr commented Jan 14, 2023

Interesting that it happens, as npm2hashicorp is only called on the results of hashicorp2npm which ought to remove all "v"s - ice done this as npm spec doesn't allow them, although I notice the implementation of npm is very forgiving

@mcfedr
Copy link
Contributor

mcfedr commented Jan 14, 2023

Im now thinking throwing wasn't a great idea in a code base that doesn't expect it!

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.102.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants