Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): augment constraints less aggressively #19850

Merged
merged 1 commit into from Jan 15, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jan 15, 2023

Changes

Augments npm constraints less aggressively by checking whether the latest 6.x or 8.x satisfies the existing constraint.

Context

Too many No matching or stable tool versions found - using an unstable version warns in the hosted app.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice January 15, 2023 06:08
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@rarkins rarkins merged commit f34d395 into main Jan 15, 2023
@rarkins rarkins deleted the fix/npm-constraint-augment branch January 15, 2023 09:24
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.102.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants