Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use a PEP440-compliant version constraint in pip-compile documentation #19855

Merged
merged 1 commit into from Jan 16, 2023
Merged

docs: Use a PEP440-compliant version constraint in pip-compile documentation #19855

merged 1 commit into from Jan 16, 2023

Conversation

TheMrMilchmann
Copy link
Contributor

Changes

Updates the example in the documentation of the pip-compile manager to declare a Python version constraint using a PEP440-compliant format.

Context

Using a Python version as suggested in the docs causes the pip-compile invocation to fail. Note, that this is especially annoying as it is not detected as a configuration error by Renovate. (I assume that the constraint is not validated.)

Relevant log excerpt of a failed run:

DEBUG: Executing command(branch="renovate/mkdocs-material-9.x")
{
  "command": "docker run --rm --name=renovate_sidecar --label=renovate_child -v \"/mnt/renovate/gh/TheMrMilchmann/sqldelight\":\"/mnt/renovate/gh/TheMrMilchmann/sqldelight\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/tmp/containerbase\":\"/tmp/containerbase\" -e PIP_CACHE_DIR -e BUILDPACK_CACHE_DIR -e CONTAINERBASE_CACHE_DIR -w \"/mnt/renovate/gh/TheMrMilchmann/sqldelight/.github/workflows\" docker.io/renovate/sidecar bash -l -c \"install-tool python 3.11 && pip install --user pip-tools && pip-compile requirements.in\""
}
DEBUG: rawExec err(branch="renovate/mkdocs-material-9.x")
{
  "err": {
    "name": "ExecError",
    "cmd": "/bin/sh -c docker run --rm --name=renovate_sidecar --label=renovate_child -v \"/mnt/renovate/gh/TheMrMilchmann/sqldelight\":\"/mnt/renovate/gh/TheMrMilchmann/sqldelight\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/tmp/containerbase\":\"/tmp/containerbase\" -e PIP_CACHE_DIR -e BUILDPACK_CACHE_DIR -e CONTAINERBASE_CACHE_DIR -w \"/mnt/renovate/gh/TheMrMilchmann/sqldelight/.github/workflows\" docker.io/renovate/sidecar bash -l -c \"install-tool python 3.11 && pip install --user pip-tools && pip-compile requirements.in\"",
    "stderr": "",
    "stdout": "Invalid version: 3.11\n",
    "options": {
      "cwd": "/mnt/renovate/gh/TheMrMilchmann/sqldelight/.github/workflows",
      "encoding": "utf-8",
      "env": {
        "PIP_CACHE_DIR": "/tmp/renovate-cache/others/pip",
        "HOME": "/home/ubuntu",
        "PATH": "/home/ubuntu/.local/bin:/home/ubuntu/bin:/opt/buildpack/tools/python/3.9.3/bin:/home/ubuntu/.npm-global/bin:/home/ubuntu/renovateapp/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
        "LC_ALL": "C.UTF-8",
        "LANG": "C.UTF-8",
        "BUILDPACK_CACHE_DIR": "/tmp/containerbase",
        "CONTAINERBASE_CACHE_DIR": "/tmp/containerbase"
      },
      "maxBuffer": 10485760,
      "timeout": 900000
    },
    "exitCode": 1,
    "message": "Command failed: docker run --rm --name=renovate_sidecar --label=renovate_child -v \"/mnt/renovate/gh/TheMrMilchmann/sqldelight\":\"/mnt/renovate/gh/TheMrMilchmann/sqldelight\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/tmp/containerbase\":\"/tmp/containerbase\" -e PIP_CACHE_DIR -e BUILDPACK_CACHE_DIR -e CONTAINERBASE_CACHE_DIR -w \"/mnt/renovate/gh/TheMrMilchmann/sqldelight/.github/workflows\" docker.io/renovate/sidecar bash -l -c \"install-tool python 3.11 && pip install --user pip-tools && pip-compile requirements.in\"\n",
    "stack": "ExecError: Command failed: docker run --rm --name=renovate_sidecar --label=renovate_child -v \"/mnt/renovate/gh/TheMrMilchmann/sqldelight\":\"/mnt/renovate/gh/TheMrMilchmann/sqldelight\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/tmp/containerbase\":\"/tmp/containerbase\" -e PIP_CACHE_DIR -e BUILDPACK_CACHE_DIR -e CONTAINERBASE_CACHE_DIR -w \"/mnt/renovate/gh/TheMrMilchmann/sqldelight/.github/workflows\" docker.io/renovate/sidecar bash -l -c \"install-tool python 3.11 && pip install --user pip-tools && pip-compile requirements.in\"\n\n    at ChildProcess.<anonymous> (/home/ubuntu/renovateapp/node_modules/renovate/dist/util/exec/common.js:87:24)\n    at ChildProcess.emit (node:events:525:35)\n    at ChildProcess.emit (node:domain:489:12)\n    at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)"
  }
}

@TheMrMilchmann TheMrMilchmann changed the title Use a PEP440-compliant version constraint in pip-compile documentation docs: Use a PEP440-compliant version constraint in pip-compile documentation Jan 15, 2023
@rarkins rarkins merged commit 5e42dae into renovatebot:main Jan 16, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.104.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants