feat(manager/terraform): support OCI charts in helm_release #19869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
requested changes
Jan 16, 2023
lib/modules/manager/terraform/extractors/resources/helm-release.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…orm-helm-release-oci-registry
secustor
requested changes
Jan 17, 2023
lib/modules/manager/terraform/extractors/resources/helm-release.ts
Outdated
Show resolved
Hide resolved
lib/modules/manager/terraform/extractors/resources/helm-release.ts
Outdated
Show resolved
Hide resolved
…e.ts Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
…e.ts Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
secustor
reviewed
Jan 17, 2023
OCI charts are also valid paths, therefore we need to check first if it is an OCI chart.
viceice
reviewed
Jan 17, 2023
morremeyer
requested review from
viceice and
secustor
and removed request for
viceice and
secustor
|
Sorry for the review re-request confusion, seems like I can only request one of you again. If I request both of you, it seems to remove all the requests. |
secustor
requested changes
Jan 17, 2023
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
I went with the layout of the existing tests to not add further complication to the PR review.
secustor
previously approved these changes
Jan 18, 2023
viceice
reviewed
Jan 18, 2023
lib/modules/manager/terraform/extractors/resources/helm-release.ts
Outdated
Show resolved
Hide resolved
lib/modules/manager/terraform/extractors/resources/helm-release.ts
Outdated
Show resolved
Hide resolved
lib/modules/manager/terraform/extractors/resources/helm-release.ts
Outdated
Show resolved
Hide resolved
You should be able to re-request review with these buttons |
|
@viceice I had the same behaviour as @morremeyer, this seems to enabled for everyone without write permissions/maintainers. |
6 tasks
…e.ts Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…e.ts Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…e.ts Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…orm-helm-release-oci-registry
|
@viceice I resolved this open question in it, since I think your prior review already approved that idea. |
secustor
approved these changes
Jan 19, 2023
viceice
approved these changes
Jan 19, 2023
|
🎉 This PR is included in version 34.106.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
jalaziz
added a commit
to jalaziz/renovate
that referenced
this pull request
Feb 6, 2023
This is a follow-up to renovatebot#19869. OCI repos can be specified as part of the chart or repository, so extend OCI registry detection to the repository field too.
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds support for helm charts published in OCI-based registries within
helm_releaseresources for the terraform manager.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: