Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(git): unset git-hooks after clone #19880

Merged
merged 4 commits into from Jan 17, 2023
Merged

fix(git): unset git-hooks after clone #19880

merged 4 commits into from Jan 17, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jan 17, 2023

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added the ci:fulltest Run full test suite on all platforms label Jan 17, 2023
@rarkins rarkins marked this pull request as ready for review January 17, 2023 15:12
@rarkins rarkins added ci:fulltest Run full test suite on all platforms and removed ci:fulltest Run full test suite on all platforms labels Jan 17, 2023
@rarkins rarkins requested a review from viceice January 17, 2023 15:29
viceice
viceice approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can there really be this setting in a fresh checkout? 🤔

@rarkins
Copy link
Collaborator Author

rarkins commented Jan 17, 2023

There's a repo which keeps failing on every branch checkout command because JAVA_HOME is not set. So we'll soon see if that's fixed by this and know

@rarkins rarkins enabled auto-merge (squash) January 17, 2023 15:46
@rarkins
Copy link
Collaborator Author

rarkins commented Jan 17, 2023

i.e. it's not a clone hook, it's a checkout hook (which happens after)

@rarkins rarkins merged commit 09fca82 into main Jan 17, 2023
@rarkins rarkins deleted the fix/git-hooks branch January 17, 2023 15:50
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.105.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

rarkins added a commit that referenced this pull request Jan 18, 2023
@rarkins
fix: Revert fix(git): unset git-hooks after clone (#19880)
c43a65f
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
ci:fulltest Run full test suite on all platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rarkins @renovate-release @viceice