Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create discussion forms #19894

Merged
merged 15 commits into from Jan 21, 2023

Conversation

HonkingGoose
Copy link
Collaborator

Changes

  • Create discussion forms for:
    • Ideas & General Discussion
    • Mend Renovate App Support
    • Questions & Answers

Context

The Poll discussion type has no form, because that's not supported by GitHub. 馃槃

Closes #19810.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously approved these changes Jan 19, 2023
@rarkins
Copy link
Collaborator

rarkins commented Jan 19, 2023

One question: if we adopt these templates, but need to convert issues to discussions, do they bypass these templates?

@HonkingGoose
Copy link
Collaborator Author

HonkingGoose commented Jan 19, 2023

There are some problems with my YAML. I'll go fix those first.

Edit: turns out name: and description: are not valid keys for Discussion Forms. 馃槃


One question: if we adopt these templates, but need to convert issues to discussions, do they bypass these templates?

Converted issues bypass the templates. I've tested this on a throwaway copy of the Renovate repository.

@HonkingGoose HonkingGoose marked this pull request as ready for review January 19, 2023 17:53
Copy link
Collaborator Author

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to merge, just wanted to highlight a gotcha. 馃槈

@rarkins rarkins merged commit cf50673 into renovatebot:main Jan 21, 2023
@HonkingGoose HonkingGoose deleted the chore/discussion-forms branch January 21, 2023 07:17
@renovate-release
Copy link
Collaborator

馃帀 This PR is included in version 34.108.3 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create discussion category forms
3 participants