Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manger/asdf): add argocd support #19941

Merged
merged 3 commits into from Jan 20, 2023
Merged

feat(manger/asdf): add argocd support #19941

merged 3 commits into from Jan 20, 2023

Conversation

julianxhokaxhiu
Copy link
Contributor

Changes

Add argocd to the asdf manager

Context

Closes #19940

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@julianxhokaxhiu julianxhokaxhiu changed the title Add argocd to the asdf manager feat: Add argocd to the asdf manager Jan 20, 2023
rarkins
rarkins previously approved these changes Jan 20, 2023
@rarkins rarkins changed the title feat: Add argocd to the asdf manager feat(asdf): add argocd support Jan 20, 2023
@rarkins rarkins enabled auto-merge (squash) January 20, 2023 11:20
@julianxhokaxhiu
Copy link
Contributor Author

Actually I am not sure how this documentation here is updated: https://docs.renovatebot.com/modules/manager/asdf/#additional-information

If there's a way to do it already on this PR LMK and I'll be happy to add argocd to the list.

@rarkins
Copy link
Collaborator

rarkins commented Jan 20, 2023

It's auto-generated! So no need to do anything, the website will be updated automatically post-release

@julianxhokaxhiu
Copy link
Contributor Author

I rebased the PR as GH was stating this branch was already out of date.

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice viceice changed the title feat(asdf): add argocd support feat(manger/asdf): add argocd support Jan 20, 2023
@rarkins rarkins merged commit 5bf6eab into renovatebot:main Jan 20, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.108.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@julianxhokaxhiu julianxhokaxhiu deleted the patch-1 branch January 20, 2023 17:48
@julianxhokaxhiu
Copy link
Contributor Author

julianxhokaxhiu commented Jan 21, 2023

https://app.renovatebot.com/dashboard#github/julianxhokaxhiu/renovate-test/981559147 the argocd plugin still comes out as unsupported 🤔

{
  "depIndex": 0,
  "depName": "argocd",
  "skipReason": "unsupported-datasource",
  "updates": []
}

Any idea why? Maybe this patch is not enough? Job is using this version:

{
  "renovateVersion": "34.108.1"
}

Probably the packageName property should have been

packageName: 'argocd',

I'm not sure.

@julianxhokaxhiu
Copy link
Contributor Author

I added a test coverage of the new argocd plugin to make sure the extract logic works correctly and in fact it does. The test passes ( see mentioned PR above ), but it is still not clear to me why the bot is not picking it up for a bump and says unsupported.

@viceice
Copy link
Member

viceice commented Jan 23, 2023

please create a new discussion instead of commenting on released PR

@julianxhokaxhiu
Copy link
Contributor Author

Ok let's follow up this on #19929

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ASDF] Support argocd plugin
4 participants