Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add changelogUrl for gradle-semver-plugin #20441

Merged
merged 13 commits into from May 16, 2023
Merged

Conversation

ahatzz11
Copy link
Contributor

@ahatzz11 ahatzz11 commented Feb 15, 2023

Changes

Add changelogUrl for gradle-semver-plugin

Context

Link to discussion: #20438

I'm adding this to get release notes to appear for our OSS gradle plugin that is only published to the Gradle Plugin Portal can show release notes in renovate PRs.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have not tested this, and I would love an extra set of eyes to make sure that I did this right. There aren't currently any gradle items here so I wasn't quite sure on syntax. For the id I used the name of the plugin that is used on the portal: https://plugins.gradle.org/plugin/com.figure.gradle.semver-plugin

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@ahatzz11 ahatzz11 changed the title Add changelogUrl for gradle-semver-plugin chore: Add changelogUrl for gradle-semver-plugin Feb 15, 2023
lib/modules/datasource/metadata-manual.ts Outdated Show resolved Hide resolved
lib/modules/datasource/metadata-manual.ts Outdated Show resolved Hide resolved
@viceice viceice changed the title chore: Add changelogUrl for gradle-semver-plugin fix: Add changelogUrl for gradle-semver-plugin Feb 16, 2023
ahatzz11 and others added 2 commits February 16, 2023 13:53
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@ahatzz11 ahatzz11 requested review from rarkins and viceice and removed request for rarkins February 16, 2023 20:04
viceice
viceice previously approved these changes Feb 17, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should sort those objects in a follow up PR

@ahatzz11 ahatzz11 requested review from viceice and rarkins May 2, 2023 22:02
viceice
viceice previously approved these changes May 3, 2023
@ahatzz11 ahatzz11 requested review from rarkins and viceice May 4, 2023 16:17
rarkins
rarkins previously approved these changes May 4, 2023
@ahatzz11
Copy link
Contributor Author

ahatzz11 commented May 8, 2023

@viceice @rarkins could this get a final review and merge? Let me know if you need anything from me!

@rarkins rarkins enabled auto-merge May 9, 2023 03:37
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
auto-merge was automatically disabled May 11, 2023 22:54

Head branch was pushed to by a user without write access

@ahatzz11 ahatzz11 requested review from rarkins and viceice May 11, 2023 22:55
rarkins
rarkins previously approved these changes May 12, 2023
@rarkins rarkins enabled auto-merge May 12, 2023 04:34
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still has linting issues. please run prettier on this file

auto-merge was automatically disabled May 15, 2023 22:26

Head branch was pushed to by a user without write access

@ahatzz11
Copy link
Contributor Author

ahatzz11 commented May 15, 2023

this still has linting issues. please run prettier on this file

@viceice sorry about that! It's all cleaned up now 👍 The dangers of editing in github

yarn run v1.22.19
warning ../../package.json: No license field
$ prettier --cache --check "**/*.{ts,js,mjs,json,md,yml}"
Checking formatting...
All matched files use Prettier code style!
✨  Done in 11.65s.

@rarkins rarkins enabled auto-merge May 16, 2023 04:39
@rarkins rarkins added this pull request to the merge queue May 16, 2023
Merged via the queue into renovatebot:main with commit 2e7aa43 May 16, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.87.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023
@ahatzz11 ahatzz11 deleted the patch-1 branch June 17, 2023 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants