Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migration): throw error for invalid hostRules #20540

Merged
merged 27 commits into from May 22, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Feb 21, 2023

Changes

  • throw error if the hostRule has more than one host options during migration

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh changed the title fix(migration): throw error for invalid hostRules fix(migration): throw error for invalid hostRules [WIP] Feb 21, 2023
lib/util/host-rules.ts Outdated Show resolved Hide resolved
lib/config/migrations/custom/host-rules-migration.ts Outdated Show resolved Hide resolved
lib/config/migrations/custom/host-rules-migration.ts Outdated Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh changed the title fix(migration): throw error for invalid hostRules [WIP] fix(migration): throw error for invalid hostRules Feb 23, 2023
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review February 23, 2023 06:23
@viceice viceice requested a review from rarkins February 23, 2023 07:17
viceice
viceice previously approved these changes Feb 23, 2023
lib/util/host-rules.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more discussion in #20539 first

lib/config/migration.spec.ts Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Apr 20, 2023

see comments

#20539 (comment)

viceice
viceice previously approved these changes Apr 29, 2023
lib/util/host-rules.ts Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@rarkins rarkins enabled auto-merge May 22, 2023 07:49
@rarkins rarkins added this pull request to the merge queue May 22, 2023
Merged via the queue into renovatebot:main with commit 0d85cea May 22, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.98.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host rules migration not working as expected
4 participants