Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matchPackageNames should match packageName + depName #20926

Closed
Tracked by #21134
rarkins opened this issue Mar 14, 2023 · 1 comment
Closed
Tracked by #21134

matchPackageNames should match packageName + depName #20926

rarkins opened this issue Mar 14, 2023 · 1 comment
Assignees
@rarkins
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality) v36

Comments

@rarkins
Copy link
Collaborator

rarkins commented Mar 14, 2023

What would you like Renovate to be able to do?

Match against both matchPackageName and matchDepName.

If you have any ideas on how this should be implemented, please tell us here.

Needs to cover all matchPackageX excludePackageX.

Should ideally warn if it does not match packageName but does match depName. In such cases it should still do the match (for backwards compatibility) but warn the user that they should use matchDepX instead.

Is this a feature you are interested in implementing yourself?

No
@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others breaking Breaking change, requires major version bump status:ready labels Mar 14, 2023
@viceice viceice mentioned this issue Mar 24, 2023
Closed
28 tasks
@rarkins rarkins self-assigned this Jun 12, 2023
rarkins added a commit that referenced this issue Jun 12, 2023
@rarkins
feat(package-rules)!: match packageName for matchPackageNames
8bc9a6a 
Closes #20926
@rarkins rarkins mentioned this issue Jun 12, 2023
Merged
6 tasks
@rarkins rarkins added status:in-progress Someone is working on implementation and removed status:ready labels Jun 12, 2023
@rarkins rarkins added the v36 label Jun 27, 2023
rarkins added a commit that referenced this issue Jul 4, 2023
@rarkins
feat(package-rules)!: match packageName for matchPackageNames (#22703)
e4e6644 
Closes #20926

BREAKING CHANGE: matchPackageNames now matches both depName (existing) and packageName (new)
rarkins added a commit that referenced this issue Jul 4, 2023
@rarkins
feat(package-rules)!: match packageName for matchPackageNames (#22703)
933e4dd 
Closes #20926

BREAKING CHANGE: matchPackageNames now matches both depName (existing) and packageName (new)
@rarkins rarkins closed this as completed in e4dead2 Jul 4, 2023
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 36.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this issue Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality) v36
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rarkins @renovate-release