feat: commitMessageLowerCase #20930

kingcrunch · 2023-03-14T16:36:44Z

Semantic-commits states, that only the first letter should be lowercased

Changes

Change the commit title formatting from "all lowercase" to "first letter lowercase" for semantic-commits.

Context

Semantic commits states, that only the first letter of the commit message should be lowercase. However, although this is not part of this change, there may be cases, where one needs to ignore this rule, for example if one needs to add JIRA-IDs to the commit title, which are traditionally all uppercase (sigh).

This is a follow-up of the discussion #20923

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository

Semantic-commits states, that only the first letter should be lowercased

kingcrunch · 2023-03-14T16:37:24Z

To be honest: Just a wild guess, because not my language (and so on). I am open for recommendations, suggestions, whatever.

viceice

doesn't work as expected, it would only lowercase the first char of the semantic commit type

HonkingGoose · 2023-03-18T10:30:09Z

I'm labeling this PR breaking because of this quote from @rarkins: ¹

Let's say we remove all commit message lower casing, probably in a major release to flag it's a breaking change.

Edit: the PR title is not breaking yet, so before merging one of the maintainers should add the ! in the correct place, so our Semantic Release bot creates a new major version.

https://github.com/renovatebot/renovate/discussions/20931#discussioncomment-5351645 ↩

rarkins · 2023-03-18T13:37:45Z

Let's refer back to the discussion until consensus is reached

BREAKING CHANGE: Before this change, the titles where all-lowercase when using `semanticCommits` (and kept as they were when not). After this change this must be explicitly set.

…sting

…it-title

according requirements, which suggests multiple options - auto - never - first (future)

kingcrunch · 2023-03-21T12:15:40Z

build / test and build / lint fail, but the issues seems to be unrelated to this PR.

kingcrunch · 2023-03-21T13:36:13Z

doesn't work as expected, it would only lowercase the first char of the semantic commit type

@viceice It's replaced now.

kingcrunch · 2023-03-21T15:07:57Z

build / test and build / lint fail, but the issues seems to be unrelated to this PR.

It was related. Fixed :)

lib/config/options/index.ts

lib/config/types.ts

lib/modules/platform/azure/index.ts

lib/modules/platform/bitbucket-server/index.ts

lib/modules/platform/azure/index.ts

lib/workers/repository/updates/generate.ts

kingcrunch · 2023-03-22T06:51:51Z

The breaking flag can be remove, no?

HonkingGoose · 2023-03-22T09:32:48Z

@rarkins is the current PR still breaking? Please keep/remove the breaking label as needed. 😉

lib/config/types.ts

lib/workers/repository/updates/generate.ts

kingcrunch · 2023-04-16T15:21:54Z

Is there is really no interest in fixing this bug?

Btw the PR is still no breaking change. It was, but I changed it.

So I don't know, why this is still postponed to the next major release.

At the end for me it was much easier to change the company rules, than fixing a bug here...

rarkins · 2023-04-17T06:15:32Z

There are currently code changes requested

kingcrunch · 2023-04-21T07:55:46Z

Hi @rarkins

Maybe there is a misunderstanding, but I cannot see any request for change. I can see two question. One for you

@rarkins should we negate to be more save against missing value?
https://github.com/renovatebot/renovate/pull/20930/files#r1154877720

and one for @JamieMagee

@JamieMagee should we add undefined for typescript?
https://github.com/renovatebot/renovate/pull/20930/files#r1154874172

So this seems to be still under discussion and it doesn't make sense for me to propose changes, that are still discussed.

I don't know your workflows, but to me it seems nobody cares...

lib/modules/platform/azure/index.ts

lib/workers/repository/updates/generate.ts

rarkins · 2023-04-21T08:42:26Z

Please check for the currently 2 unresolved comments in https://github.com/renovatebot/renovate/pull/20930/files

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

docs/usage/configuration-options.md

viceice

markdown config needs sorted, otherwise LGTM

viceice

markdown config needs sorted, otherwise LGTM

renovate-release · 2023-05-13T19:06:38Z

🎉 This PR is included in version 35.82.0 🎉

The release is available on:

GitHub release
35.82.0

Your semantic-release bot 📦🚀

Co-authored-by: Michael Kriese <michael.kriese@visualon.de> Co-authored-by: Rhys Arkins <rhys@arkins.net>

fix: Do not lowercase entire commit title

d9faf55

Semantic-commits states, that only the first letter should be lowercased

viceice requested changes Mar 14, 2023

View reviewed changes

HonkingGoose added the breaking Breaking change, requires major version bump label Mar 18, 2023

rarkins closed this Mar 18, 2023

kingcrunch added 4 commits March 18, 2023 15:38

feat: introduce new option to change case of titles

5072c16

BREAKING CHANGE: Before this change, the titles where all-lowercase when using `semanticCommits` (and kept as they were when not). After this change this must be explicitly set.

feat: compare branch- and pr-title case-insensitive when fetching exi…

39184ef

…sting

Merge branch 'renovatebot:main' into fix/do-not-lowercase-entire-comm…

993f70d

…it-title

feat: Change commitMessageLowercase from bool to string

3521ebc

according requirements, which suggests multiple options - auto - never - first (future)

rarkins reopened this Mar 21, 2023

rarkins requested a review from JamieMagee as a code owner March 21, 2023 11:57

rarkins changed the title ~~fix: Do not lowercase entire commit title~~ feat: commitMessageLowerCase Mar 21, 2023

kingcrunch requested review from viceice and removed request for JamieMagee March 21, 2023 14:27

fix: Objects may be undefined

b98a6c1

viceice requested changes Mar 21, 2023

View reviewed changes

kingcrunch added 2 commits March 21, 2023 20:41

fix: After review

c7badf0

fix: Wording

c9e9e60

kingcrunch requested a review from viceice March 21, 2023 19:47

viceice mentioned this pull request Mar 24, 2023

v36 planning #21134

Closed

28 tasks

viceice reviewed Mar 31, 2023

View reviewed changes

lib/config/types.ts Show resolved Hide resolved

lib/workers/repository/updates/generate.ts Outdated Show resolved Hide resolved

lib/workers/repository/updates/generate.ts Outdated Show resolved Hide resolved

viceice requested a review from rarkins April 16, 2023 18:23

viceice requested review from JamieMagee and secustor April 16, 2023 18:23

rarkins removed the breaking Breaking change, requires major version bump label Apr 17, 2023

rarkins reviewed Apr 21, 2023

View reviewed changes

lib/modules/platform/azure/index.ts Outdated Show resolved Hide resolved

lib/workers/repository/updates/generate.ts Outdated Show resolved Hide resolved

Xavientois mentioned this pull request Apr 21, 2023

Commit messages should not be fully lowercased #12062

Closed

chore: apply suggestions from code review

f57f5ef

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

rarkins requested changes Apr 27, 2023

View reviewed changes

docs/usage/configuration-options.md Outdated Show resolved Hide resolved

rarkins added 2 commits April 27, 2023 09:45

Update docs/usage/configuration-options.md

996167c

Merge branch 'main' into fix/do-not-lowercase-entire-commit-title

23d7b10

rarkins requested a review from viceice April 27, 2023 07:53

rarkins previously approved these changes Apr 27, 2023

View reviewed changes

viceice reviewed May 12, 2023

View reviewed changes

docs/usage/configuration-options.md Outdated Show resolved Hide resolved

viceice reviewed May 12, 2023

View reviewed changes

fix: alphabetical order

67a712f

kingcrunch dismissed rarkins’s stale review via 67a712f May 12, 2023 08:08

rarkins approved these changes May 12, 2023

View reviewed changes

rarkins enabled auto-merge May 12, 2023 08:12

rarkins requested a review from viceice May 12, 2023 08:12

rarkins added this pull request to the merge queue May 13, 2023

viceice approved these changes May 13, 2023

View reviewed changes

Merged via the queue into renovatebot:main with commit fc73b07 May 13, 2023
11 checks passed

mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023

feat: commitMessageLowerCase (renovatebot#20930)

2a0ca5c

Co-authored-by: Michael Kriese <michael.kriese@visualon.de> Co-authored-by: Rhys Arkins <rhys@arkins.net>

github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: commitMessageLowerCase #20930

feat: commitMessageLowerCase #20930

kingcrunch commented Mar 14, 2023 •

edited

kingcrunch commented Mar 14, 2023

viceice left a comment

HonkingGoose commented Mar 18, 2023 •

edited

rarkins commented Mar 18, 2023

kingcrunch commented Mar 21, 2023

kingcrunch commented Mar 21, 2023

kingcrunch commented Mar 21, 2023

kingcrunch commented Mar 22, 2023

HonkingGoose commented Mar 22, 2023

kingcrunch commented Apr 16, 2023

rarkins commented Apr 17, 2023

kingcrunch commented Apr 21, 2023

rarkins commented Apr 21, 2023

viceice left a comment

viceice left a comment

renovate-release commented May 13, 2023

feat: commitMessageLowerCase #20930

feat: commitMessageLowerCase #20930

Conversation

kingcrunch commented Mar 14, 2023 • edited

Changes

Context

Documentation (please check one with an [x])

How I've tested my work (please select one)

kingcrunch commented Mar 14, 2023

viceice left a comment

Choose a reason for hiding this comment

HonkingGoose commented Mar 18, 2023 • edited

Footnotes

rarkins commented Mar 18, 2023

kingcrunch commented Mar 21, 2023

kingcrunch commented Mar 21, 2023

kingcrunch commented Mar 21, 2023

kingcrunch commented Mar 22, 2023

HonkingGoose commented Mar 22, 2023

kingcrunch commented Apr 16, 2023

rarkins commented Apr 17, 2023

kingcrunch commented Apr 21, 2023

rarkins commented Apr 21, 2023

viceice left a comment

Choose a reason for hiding this comment

viceice left a comment

Choose a reason for hiding this comment

renovate-release commented May 13, 2023

kingcrunch commented Mar 14, 2023 •

edited

HonkingGoose commented Mar 18, 2023 •

edited