Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform/gitlab)!: prefer commit_email (#21122 #21122

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Mar 24, 2023

Changes

Not sure if this should be considered breaking?

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice added the platform:gitlab GitLab Platform label Mar 24, 2023
@rarkins
Copy link
Collaborator

rarkins commented Mar 24, 2023

I think so. Let's release in v36 with categories

@viceice viceice added the breaking Breaking change, requires major version bump label Mar 24, 2023
@viceice viceice assigned viceice and unassigned viceice Mar 24, 2023
@viceice viceice marked this pull request as draft March 24, 2023 09:03
@viceice viceice mentioned this pull request Mar 24, 2023
28 tasks
@rarkins rarkins changed the base branch from main to v36 April 26, 2023 06:24
@rarkins rarkins marked this pull request as ready for review April 26, 2023 06:24
@rarkins rarkins changed the title feat(platform/gitlab): prefer commit_email feat(platform/gitlab)!: prefer commit_email Apr 26, 2023
@rarkins rarkins changed the title feat(platform/gitlab)!: prefer commit_email feat(platform/gitlab)!: prefer commit_email (#21122 Apr 26, 2023
@rarkins rarkins merged commit fa04c8a into v36 Apr 26, 2023
3 checks passed
@rarkins rarkins deleted the feat/gitlab/commit-email branch April 26, 2023 06:26
rarkins pushed a commit that referenced this pull request May 7, 2023
gitAuthor discover for GitLab now prefers the field `commit_email` over `email`.

BREAKING CHANGE: GitLab gitAuthor will change from the account's "email" to "commit_email" if they are different.
rarkins pushed a commit that referenced this pull request May 10, 2023
gitAuthor discover for GitLab now prefers the field `commit_email` over `email`.

BREAKING CHANGE: GitLab gitAuthor will change from the account's "email" to "commit_email" if they are different.
rarkins pushed a commit that referenced this pull request May 23, 2023
gitAuthor discover for GitLab now prefers the field `commit_email` over `email`.

BREAKING CHANGE: GitLab gitAuthor will change from the account's "email" to "commit_email" if they are different.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump platform:gitlab GitLab Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GitLab] Change email source in gitAuthor
2 participants