feat(presets)!: rename `config:base` to `config:recommended` #21136

viceice · 2023-03-24T20:27:35Z

Changes

rename with migration

Context

closes Rename config:base -> config:recommended #12024

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository

lib/config/presets/common.ts

docs/usage/config-presets.md

lib/config/presets/internal/config.ts

HonkingGoose · 2023-03-29T22:07:45Z

This PR targets the main branch. Should this PR target v36 branch instead?

We probably don't want to accidentally release a v36 just for the rename from config:base to config:recommended. 🙈

viceice · 2023-03-30T18:48:19Z

We'll retarget when we prepare v36, until ten it's easier to rebase onto main.

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

gitAuthor discover for GitLab now prefers the field `commit_email` over `email`. BREAKING CHANGE: GitLab gitAuthor will change from the account's "email" to "commit_email" if they are different.

Set `{ dot: true }` for minimatch. BREAKING CHANGE: dot files will now be included by default for all minimatch results

HonkingGoose · 2023-05-15T10:34:47Z

@viceice I think we're working on v36 now, so it's probably a good time to re-target this PR to the v36 branch. 😉

Co-authored-by: Rhys Arkins <rhys@arkins.net>

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

rarkins · 2023-05-15T12:22:16Z

Does this handle the scenario where a self-hosted user has configured an onboardingConfig containing config:base? Ideally we should raise the actual onboarding PR with config:recommended not config:base

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

gitAuthor discover for GitLab now prefers the field `commit_email` over `email`. BREAKING CHANGE: GitLab gitAuthor will change from the account's "email" to "commit_email" if they are different.

Set `{ dot: true }` for minimatch. BREAKING CHANGE: dot files will now be included by default for all minimatch results

docs/development/creating-editing-renovate-presets.md

docs/usage/config-presets.md

Co-authored-by: Rhys Arkins <rhys@arkins.net> Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Co-authored-by: Bastian Gutschke <bastian.gutschke@gmx.de>

Closes #12024 Co-authored-by: Rhys Arkins <rhys@arkins.net> Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Co-authored-by: Bastian Gutschke <bastian.gutschke@gmx.de> BREAKING CHANGE: Preset config:base is now called config:recommended

dpprdan · 2023-07-20T13:21:43Z

@viceice Shouldn't

renovate/lib/config/presets/internal/config.ts

Line 10 in f19b300

'config:base',

also become config:recommended?

HonkingGoose · 2023-07-20T16:04:34Z

@dpprdan Good catch, see issue:

Replace config:base with config:recommended in preset code #23326

viceice added breaking Breaking change, requires major version bump core:config Related to config capabilities and presets labels Mar 24, 2023

viceice requested a review from rarkins March 24, 2023 20:27

viceice mentioned this pull request Mar 24, 2023

v36 planning #21134

Closed

28 tasks

rarkins requested changes Mar 25, 2023

View reviewed changes

lib/config/presets/common.ts Outdated Show resolved Hide resolved

docs/usage/config-presets.md Show resolved Hide resolved

HonkingGoose reviewed Mar 26, 2023

View reviewed changes

lib/config/presets/internal/config.ts Outdated Show resolved Hide resolved

rarkins and others added 6 commits May 10, 2023 09:05

feat!: allow post upgrade templating by default (#21326)

0039e8d

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

feat(automerge)!: default to platformAutomerge=true (#21327)

63ac11e

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

feat(platform/gitlab)!: prefer commit_email (#21122

17849cc

gitAuthor discover for GitLab now prefers the field `commit_email` over `email`. BREAKING CHANGE: GitLab gitAuthor will change from the account's "email" to "commit_email" if they are different.

fix(post-upgrade-tasks)!: enable dot option for file filters (#21282)

854bbaf

Set `{ dot: true }` for minimatch. BREAKING CHANGE: dot files will now be included by default for all minimatch results

feat(npm)!: disable rollbackPrs for npm by default (#21970)

a562b93

fix(presets)!: remove compatibility:additionalBranchPrefix (#22015)

a640971

viceice changed the base branch from main to v36 May 15, 2023 11:36

viceice and others added 3 commits May 15, 2023 13:37

feat(presets)!: rename config:base to config:recommended

5ee0352

Update lib/config/presets/common.ts

c05174b

Co-authored-by: Rhys Arkins <rhys@arkins.net>

Update lib/config/presets/internal/config.ts

b833e19

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

viceice force-pushed the feat/presets/rename-base2recommend branch from 42d91d9 to b833e19 Compare May 15, 2023 11:37

viceice marked this pull request as ready for review May 15, 2023 11:37

viceice requested a review from rarkins May 15, 2023 11:37

rarkins force-pushed the v36 branch from a640971 to 8bbd60c Compare May 23, 2023 14:18

rarkins and others added 6 commits June 12, 2023 13:49

feat!: allow post upgrade templating by default (#21326)

1169d19

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

feat(automerge)!: default to platformAutomerge=true (#21327)

a9f5219

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

feat(platform/gitlab)!: prefer commit_email (#21122

c1b63f6

gitAuthor discover for GitLab now prefers the field `commit_email` over `email`. BREAKING CHANGE: GitLab gitAuthor will change from the account's "email" to "commit_email" if they are different.

fix(post-upgrade-tasks)!: enable dot option for file filters (#21282)

ca7357f

Set `{ dot: true }` for minimatch. BREAKING CHANGE: dot files will now be included by default for all minimatch results

feat(npm)!: disable rollbackPrs for npm by default (#21970)

bbc72d9

fix(presets)!: remove compatibility:additionalBranchPrefix (#22015)

3f432a4

rarkins added 3 commits June 12, 2023 16:50

fix(presets)!: remove compatibility:additionalBranchPrefix (#22015)

90975fb

feat(package-rules)!: remove fuzzy matchPaths matching (#22394)

88ab057

feat!: merge matchPaths and matchFiles into matchFileNames (#22406)

86831e4

rarkins force-pushed the v36 branch from 107e2bc to 86831e4 Compare June 12, 2023 14:50

Merge branch 'v36' into feat/presets/rename-base2recommend

ba320ce

rarkins requested a review from HonkingGoose June 12, 2023 15:10

HonkingGoose suggested changes Jun 12, 2023

View reviewed changes

docs/development/creating-editing-renovate-presets.md Show resolved Hide resolved

docs/usage/config-presets.md Show resolved Hide resolved

rarkins force-pushed the v36 branch 4 times, most recently from a759d49 to f0ca46e Compare June 18, 2023 10:18

rarkins force-pushed the v36 branch from 7cc60bb to 6432496 Compare June 27, 2023 08:59

rarkins added 3 commits June 27, 2023 13:30

Merge branch 'v36' into feat/presets/rename-base2recommend

3688fb7

prettier

cf8d0f2

docs

b69ec80

rarkins requested a review from HonkingGoose June 27, 2023 12:19

rarkins approved these changes Jun 27, 2023

View reviewed changes

rarkins merged commit 6b282e6 into v36 Jun 27, 2023
33 checks passed

rarkins deleted the feat/presets/rename-base2recommend branch June 27, 2023 12:26

github-actions bot mentioned this pull request Jul 9, 2023

Upgrade renovate to get pnpm dependencies reported correctly AurorNZ/report-updated-dependencies#661

Merged

github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(presets)!: rename `config:base` to `config:recommended` #21136

feat(presets)!: rename `config:base` to `config:recommended` #21136

viceice commented Mar 24, 2023 •

edited

HonkingGoose commented Mar 29, 2023

viceice commented Mar 30, 2023

HonkingGoose commented May 15, 2023

rarkins commented May 15, 2023

dpprdan commented Jul 20, 2023

HonkingGoose commented Jul 20, 2023

feat(presets)!: rename config:base to config:recommended #21136

feat(presets)!: rename config:base to config:recommended #21136

Conversation

viceice commented Mar 24, 2023 • edited

Changes

Context

Documentation (please check one with an [x])

How I've tested my work (please select one)

HonkingGoose commented Mar 29, 2023

viceice commented Mar 30, 2023

HonkingGoose commented May 15, 2023

rarkins commented May 15, 2023

dpprdan commented Jul 20, 2023

HonkingGoose commented Jul 20, 2023

feat(presets)!: rename `config:base` to `config:recommended` #21136

feat(presets)!: rename `config:base` to `config:recommended` #21136

viceice commented Mar 24, 2023 •

edited