Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dockerImagePrefix with configurable sidecar image #21217

Closed
Tracked by #21134
rarkins opened this issue Mar 29, 2023 · 8 comments · Fixed by #22708
Closed
Tracked by #21134

Replace dockerImagePrefix with configurable sidecar image #21217

rarkins opened this issue Mar 29, 2023 · 8 comments · Fixed by #22708
Assignees
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality) v36

Comments

@rarkins
Copy link
Collaborator

rarkins commented Mar 29, 2023

What would you like Renovate to be able to do?

Allow a configurable/deterministic sidecar image to be configured for self-hosted users.

If you have any ideas on how this should be implemented, please tell us here.

Remove dockerImagePrefix as a config option.

Add sidecarImage as a new global config option, defaulting to containerbase/sidecar:x.y.z. It should be used instead during binarySource=docker sidecar executions.

No need to migrate - we should declare it as a breaking change.

Also configure a regex manager to keep sidecar updated within the Renovate repo.

Is this a feature you are interested in implementing yourself?

No

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others breaking Breaking change, requires major version bump status:ready labels Mar 29, 2023
@secustor secustor mentioned this issue Mar 29, 2023
28 tasks
@viceice
Copy link
Member

viceice commented Mar 29, 2023

We should also add the version to a const, so we can validate on install|docker mode that the used containerbase version is greater or equal.

@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented Jun 12, 2023

Reproduction for regexManager which will update the sidecarImage verison in renovate repo:
RahulGautamSingh-testing/sidecar-image#2

RegexManager:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "regexManagers": [
    {
      "fileMatch": ["config/options/index.ts"],
      "matchStrings": [
        "default: 'ghcr.io/containerbase/sidecar:(?<currentValue>.*)'"
      ],
      "depNameTemplate": "containerbase/sidecar",
      "datasourceTemplate": "docker"
    }
  ]
}

@RahulGautamSingh
Copy link
Collaborator

Should both the replacement and regexManager be added in the same PR?

@rarkins
Copy link
Collaborator Author

rarkins commented Jun 12, 2023

Yes

@viceice
Copy link
Member

viceice commented Jun 12, 2023

use docker datasource instead of GitHub releases, because on a publish failure the image can be missing

@viceice
Copy link
Member

viceice commented Jun 12, 2023

also node versioning is wrong. use leave versioning empty to use docker versioning

@rarkins rarkins added status:in-progress Someone is working on implementation and removed status:ready labels Jun 12, 2023
@RahulGautamSingh
Copy link
Collaborator

use docker datasource instead of GitHub releases, because on a publish failure the image can be missing

Updated

@rarkins rarkins added the v36 label Jun 27, 2023
rarkins pushed a commit that referenced this issue Jul 4, 2023
Closes #21217

BREAKING CHANGE: dockerImagePrefix is now replaced by dockerSidecarImage
rarkins pushed a commit that referenced this issue Jul 4, 2023
Closes #21217

BREAKING CHANGE: dockerImagePrefix is now replaced by dockerSidecarImage
@rarkins rarkins closed this as completed in aa14b77 Jul 4, 2023
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 36.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality) v36
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants